Added optional headers param in fetchEntries method.#58
Open
nadav96 wants to merge 2 commits intoguoguo12:masterfrom
Open
Added optional headers param in fetchEntries method.#58nadav96 wants to merge 2 commits intoguoguo12:masterfrom
nadav96 wants to merge 2 commits intoguoguo12:masterfrom
Conversation
Owner
|
Good call. Can you add |
Owner
|
Thanks! And can you rebase and check that the test suite passes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw in previous versions of the repo the program added a fixed user agent, which caused problems (403 errors).
But I do think the option to add user agent to the request (or any other header) is important, to identify the program etc..
Please let me know what you think 😊