Skip to content

Added optional headers param in fetchEntries method. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadav96 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added optional headers param in fetchEntries method. #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8208274
added optional headers param in fetchEntries method.
nadav96 Sep 3, 2019
8033f1b
moved the header param to the constructor instead of the fetch method
nadav96 Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions billboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class ChartData:
(highest first).
"""

def __init__(self, name, date=None, fetch=True, timeout=25):
def __init__(self, name, date=None, fetch=True, timeout=25, headers={}):
"""Constructs a new ChartData instance.

Args:
Expand Down Expand Up @@ -146,6 +146,7 @@ def __init__(self, name, date=None, fetch=True, timeout=25):
self.previousDate = None

self._timeout = timeout
self._headers = headers

self.entries = []
if fetch:
Expand Down Expand Up @@ -196,7 +197,7 @@ def fetchEntries(self):
else:
url = "http://www.billboard.com/charts/%s/%s" % (self.name, self.date)

req = requests.get(url, timeout=self._timeout)
req = requests.get(url, timeout=self._timeout, headers=self._headers)
if req.status_code == 404:
message = "Chart not found (perhaps the name is misspelled?)"
raise BillboardNotFoundException(message)
Expand Down