refactor: rename mostRecentCompletionDate to lastActivity#152
Merged
owengretzinger merged 1 commit intomainfrom Jan 27, 2025
Merged
Conversation
Collaborator
Author
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (01/11/25)1 reviewer was added to this PR based on Owen Gretzinger's automation. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/api/habits/types.ts: Evaluated as low risk
- src/api/habits/use-create-habit.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/api/habits/use-habits.tsx:34
- Redundant conversion of lastActivity to a Date object. If participant.lastActivity is already a Date object, this conversion is unnecessary and could introduce a bug if lastActivity is not a valid date string.
lastActivity: new Date(participant.lastActivity),
This was referenced Jan 11, 2025
AnkushSarkar10
approved these changes
Jan 27, 2025
Collaborator
Author
Merge activity
|
owengretzinger
deleted the
01-11-refactor_rename_mostrecentcompletiondate_to_lastactivity
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Renamed
mostRecentCompletionDatetolastActivityand added participant ID to habit data structure.What changed?
mostRecentCompletionDatefield tolastActivityacross all habit-related filesuse-habit-completionsexportWhy make this change?
The rename from
mostRecentCompletionDatetolastActivitybetter reflects the field's purpose, as it tracks general user activity rather than just completions. Adding participant IDs improves data consistency and makes it easier to reference specific participants throughout the application.