chore: remove max-lines-per-function eslint rule#157
Merged
owengretzinger merged 1 commit intomainfrom Jan 27, 2025
Merged
Conversation
This was referenced Jan 17, 2025
Collaborator
Author
owengretzinger
changed the title
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (01/17/25)1 reviewer was added to this PR based on Owen Gretzinger's automation. |
owengretzinger
force-pushed
the
01-17-feat_respond_to_notification_functionality
branch
from
492d5b1 to
a423843
Compare
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
b230022 to
c95ad01
Compare
owengretzinger
force-pushed
the
01-17-feat_respond_to_notification_functionality
branch
from
a423843 to
e6b12dd
Compare
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
c95ad01 to
09db1f7
Compare
owengretzinger
force-pushed
the
01-17-feat_respond_to_notification_functionality
branch
from
e6b12dd to
adb931f
Compare
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
09db1f7 to
d8c99d2
Compare
owengretzinger
force-pushed
the
01-17-feat_respond_to_notification_functionality
branch
2 times, most recently
from
f05f966 to
b427b7a
Compare
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
d8c99d2 to
e6cefd4
Compare
owengretzinger
changed the base branch from
01-17-feat_respond_to_notification_functionality
to
graphite-base/157
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
e6cefd4 to
ac6d7dd
Compare
owengretzinger
force-pushed
the
graphite-base/157
branch
from
b427b7a to
3581326
Compare
owengretzinger
force-pushed
the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
from
ac6d7dd to
f83aa3a
Compare
AnkushSarkar10
approved these changes
Jan 27, 2025
Collaborator
Author
Merge activity
|
owengretzinger
deleted the
01-17-refactor_remove_eslint_max-lines-per-function_rule
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Removed the
max-lines-per-functionESLint rule and its related disable comments throughout the codebase.What changed?
max-lines-per-functionrule from.eslintrc.jseslint-disable max-lines-per-functioncomments from various files across the projectWhy make this change?
The
max-lines-per-functionrule was creating unnecessary constraints and noise in the codebase. Some functions legitimately needed to be longer due to their complexity or UI rendering requirements. Removing this rule allows for more flexible function lengths while maintaining other code quality standards.