feat: firebase auth implementation#160
Merged
AnkushSarkar10 merged 1 commit intomainfrom Mar 25, 2025
Merged
Conversation
AnkushSarkar10
force-pushed
the
02-05-feat_firebase_auth_implementation
branch
2 times, most recently
from
d1efbd6 to
ac559e6
Compare
Collaborator
owengretzinger
left a comment
owengretzinger
left a comment
There was a problem hiding this comment.
Can we use MMKV? And then we should be able to get rid of all the async stuff unless it depends on the server.
If it doesn't get rid of all the async, can we create a hook so that we don't need the loading useStates everywhere?
Also fix type errors
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (02/09/25)1 reviewer was added to this PR based on Owen Gretzinger's automation. |
AnkushSarkar10
force-pushed
the
02-05-feat_firebase_auth_implementation
branch
from
ac559e6 to
4483bef
Compare
AnkushSarkar10
force-pushed
the
02-05-feat_firebase_auth_implementation
branch
from
4483bef to
cc0d367
Compare
owengretzinger
requested changes
Feb 27, 2025
Collaborator
|
Also can you change the default pfp to an actual placeholder pfp |
AnkushSarkar10
force-pushed
the
02-05-feat_firebase_auth_implementation
branch
from
cc0d367 to
638cb92
Compare
Merged
owengretzinger
approved these changes
Mar 25, 2025
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all the auth