Skip to content

feat: edit profile page#161

Merged
AnkushSarkar10 merged 1 commit intomainfrom
03-22-feat_edit_profile_page
Mar 25, 2025
Merged

feat: edit profile page#161
AnkushSarkar10 merged 1 commit intomainfrom
03-22-feat_edit_profile_page

Conversation

@AnkushSarkar10
Copy link
Collaborator

@AnkushSarkar10 AnkushSarkar10 commented Mar 22, 2025

edit profile page

TL;DR

Replaced the separate create/edit profile screens with a unified component that handles both creation and editing of user profiles.

What changed?

  • Renamed create-profile.tsx to create-edit-profile.tsx and enhanced it to support both profile creation and editing
  • Added an "Edit Profile" button to the Settings screen
  • Updated profile creation flow to use the new unified component with a mode parameter
  • Replaced the default profile picture from JPG to PNG format
  • Implemented profile data fetching when in edit mode
  • Added functionality to update existing user profiles in Firestore
  • Removed the unused /settings/edit-profile.tsx file

How to test?

  1. New User Flow:

    • Sign up with a new account
    • Verify you're redirected to the profile creation screen
    • Create a profile and confirm you're redirected to the main app
  2. Edit Profile Flow:

    • Log in with an existing account
    • Go to Settings
    • Click "Edit Profile"
    • Modify your profile information and save
    • Verify changes are persisted

Why make this change?

This change improves code maintainability by consolidating duplicate functionality into a single component. It also enhances the user experience by providing a consistent interface for both creating and editing profiles, while adding the missing ability for users to update their profile information after initial creation.

Copy link
Collaborator Author

AnkushSarkar10 commented Mar 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@AnkushSarkar10 AnkushSarkar10 marked this pull request as ready for review March 22, 2025 22:23
@AnkushSarkar10 AnkushSarkar10 force-pushed the 03-22-feat_edit_profile_page branch 2 times, most recently from d9c0a25 to f95eaaa Compare March 25, 2025 01:27
@AnkushSarkar10 AnkushSarkar10 changed the base branch from 02-05-feat_firebase_auth_implementation to graphite-base/161 March 25, 2025 04:12
@AnkushSarkar10 AnkushSarkar10 force-pushed the 03-22-feat_edit_profile_page branch from f95eaaa to d156d27 Compare March 25, 2025 04:12
@graphite-app graphite-app bot changed the base branch from graphite-base/161 to main March 25, 2025 04:12
@AnkushSarkar10 AnkushSarkar10 force-pushed the 03-22-feat_edit_profile_page branch from d156d27 to e019381 Compare March 25, 2025 04:13
@AnkushSarkar10 AnkushSarkar10 merged commit bcffa8f into main Mar 25, 2025
2 checks passed
Copy link
Collaborator Author

Merge activity

  • Mar 25, 12:23 AM EDT: A user merged this pull request with Graphite.

@AnkushSarkar10 AnkushSarkar10 deleted the 03-22-feat_edit_profile_page branch March 25, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants