-
-
Notifications
You must be signed in to change notification settings - Fork 843
Remove Kristen Cardon from leadership section #8197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Kristen Cardon from leadership section #8197
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Mon-Sat after 6pm PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @praytoo ! Thank you for taking on this issue!
Things Done Well
- The pull request done with the correct branch.
- Issue is linked and understandable.
- Appropriate changes in the Files Changed tab.
- The changes can be seen in the browser.
Requested Changes
- CodeQL Alerts have not been properly checked. Please check for CodeQL Alerts (near the bottom of this page), then select the appropriate checkbox in your pull request post.
- Screenshots: please include screenshots in the bottom of your pull request post. A gif demonstration can be found in 3.1.b in
CONTRIBUTING.md.
Notes:
- I really like your use of backticks in the pull request comment, it really helps clarify that your referencing files or project code. I'm need to start using that myself!
Once you've made these changes, go ahead a re-request a review from me. Thank you for your hard work! Don't hesitate to reach out if you have any questions.
|
Hi @FatCatLikesBeer 👋 Thanks again for the feedback!
✅ Visual ConfirmationBeforeAfterKristen Cardon has been removed from the leadership section as intended. |
|
Hi @praytoo -- I think @FatCatLikesBeer is saying you should include screen caps of the visual changes to the website, not snips of changes to your code. Also, the screen captures should be included as part of the main PR description rather than in a comment. You can see on the currently hosted version of the HfLA website project page that Kristen's card is present under project leadership. With your change, Kristen's card should be removed, and we want the PR description to show the before/after. To be able to see the effect of your code change before it is integrated into the official HfLA codebase, you will need to serve the page locally on your machine -- steps to do that are in CONTRIBUTING.md. If you can do that, you'll be able to confirm your changes work locally before they're merged, and grab before/after screenshots easily Please reach out if you need any help! |
|
Hi @praytoo , thank you for the quick turn around! A couple clarifications, in my previous comment, I made a mistake when saying your "pull request comment". I should have said your "pull request post". I've updated my comment to reflect that. The expected screenshots are of the website itself, not screenshots of the code. An example can be found here #8116 at the bottom the post (click the little triangle thingies). Again, thank you for the quick response, and thank you for your hard work! 💪🏽 |
|
Hi @ryanfkeller @FatCatLikesBeer im running into an issue when I try to run Jekyll to visit the local site the error says I have @import “main” in the file and $absolute_url: “{{ site.url }}”; in the file and that's causing the error but when I initially got the error I deleted it from the file…but like I said the error persists even after I’ve deleted those commands and replaced it with @use "../../_sass/main":, can you help me trouble shoot this issue so I can post the screenshots of the site? Thank you |
|
Hi @praytoo -- you shouldn't need to execute Jekyll manually from the command line like it seems you are doing. Have you read and tried the steps in CONTRIBUTING.md* to serve the website? If so, let me know which step got you stuck. If not, you'll probably want to revert the non-PR related local changes you made (i.e., restore the file you deleted and undo other changes), then try launching the Jekyll server with docker. The server should dynamically detect code changes and update your locally hosted the website as you go. *Note that you may need to use |
|
Okay I'll give this a go once I'm back at my laptop and I'll update you as I go thank you @ryanfkeller |
|
Hi @ryanfkeller — I’ve been trying to follow the Docker workflow to serve the site locally, but I keep running into persistent gem and bundler errors inside the container. I’ve tried:
But I'm still getting errors like Would love guidance on next steps to get the site running with Docker so I can provide the before/after screenshots. Thank you |
|
Hi @praytoo, Sorry for the trouble you're having! I think you're headed down the right path with The When you run If this seems possible, my recommendation would be to:
This would preserve your actual work while eliminating any local Jekyll artifacts, and hopefully should resolve the gem dependency issue since the container will start in a clean environment. Let us know how this goes, and please reach out here or on slack if you run into issues, or if this doesn't work! Local environment setup is all part of the fun... |
|
hello @FatCatLikesBeer ive updated my original post to reflect the requested before and after screenshots! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praytoo The requested changes have been made, PR is approved. Thank you for your hard work, this one seamed like a real headache. I commend you, the effort you put really shows!
@ryanfkeller Thank you so much for the support, your contributions were a total lifeline! Thank you!
|
Thank you @FatCatLikesBeer it was my first ever issue, glad we made it through, the journey was worth it! |
|
@ryanfkeller also thank you for your contributions! |
|
Review ETA: 6 PM 6/26/25 |
nubilaxl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I love what you have done, Praytoo!
|
Thank you @nubilaxl ! It was my first issue ever so I'm happy you liked it! |
|
Nice one! Thanks for working on this. I have verified the changes are accurate and will now merge. 🎉 |



Fixes #8010
What changes did you make?
leadershipsection in_projects/website.mdas instructed in issue Update Project Profile: Website- Remove Kristen Cardon #8010.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied