Skip to content

Conversation

@t-will-gillis
Copy link
Member

Fixes #8239

What changes did you make?

  • In the removeInactiveMembers() function of trim-inactive-member.js, change the previous 'or' condition to 'and'.

Why did you make the changes (we will use this info to test)?

  • This section of the function indicates that the process should continue if the member is not on the previousContributors list (because they are inactive), AND the member also is not on the inactiveWithOpenIssue list.
  • The previous OR condition resulted in some members being removed who had activity.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

change 'or' condition to 'and' in `removeInactiveMembers`
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-bug-fix-sch-monthly-8239 gh-pages
git pull https://github.com/t-will-gillis/website.git bug-fix-sch-monthly-8239

@github-actions github-actions bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 2, 2025
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Jul 2, 2025
@t-will-gillis t-will-gillis merged commit f4db1a8 into hackforla:gh-pages Jul 2, 2025
7 checks passed
@t-will-gillis t-will-gillis deleted the bug-fix-sch-monthly-8239 branch July 2, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Bug fix: "Schedule Monthly" workflow

1 participant