Skip to content

Bug fix: "Schedule Monthly" workflow #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-will-gillis merged 1 commit into from
Jul 2, 2025
Merged

Bug fix: "Schedule Monthly" workflow #8240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions github-actions/trigger-schedule/list-inactive-members/trim-inactive-members.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ async function removeInactiveMembers(previousContributors, inactiveWithOpenSkill
const removedMembers = [];
const previouslyNotified = await readPreviousNotifyList();

// Loop over team members and remove them from the team if they
// are not in either previousContributors or inactiveWithOpenIssue
// Loop over team members and remove them from the team if they are not on the previousContributors
// list (i.e. they are inactive) and they are also not on the inactiveWithOpenIssue list
for (const username in currentTeamMembers) {
if ((!previousContributors[username]) || !(username in inactiveWithOpenIssue)) {
if ((!previousContributors[username]) && !(username in inactiveWithOpenIssue)) {
// Prior to deletion, confirm that member is on the baseTeam
await addTeamMember(github, context, baseTeam, username);
// If member was not on the previouslyNotified list, do not remove yet
Expand Down