fix implicitly nullable via default value null for PHP-8.4

[txdFabio]

use of explicit nullable type for php-8.4 compatibility

[aik099]

This change breaks support for PHP versions below PHP 7.2.

[txdFabio]

you're right... can we change composer requirements to supporto only newer versions? Do I have to submit another PR?

[aik099]

@davedevelopment, should we raise the minimum supported PHP version of the library (e.g., to PHP 7.2) to allow changes like the one proposed in this PR to work on PHP 8.4?

[PNardman]

• 1 already waiting for this. 👍

[PNardman]

Any update on when this could be merged? Updated?

[aik099]

Any update on when this could be merged? Updated?

@PNardma , no updates.

@davedevelopment , ping.

[PNardman]

Still no update. 😢

[aik099]

Still no update. 😢

@PNardman , Please try contacting @davedevelopment and other library maintainers by other communication channels (e.g. e-mail, twitter, etc.).

[davedevelopment]

I'm sorry, I've been away from Hamcrest for some time and completely forgot about my responsibilities here. Generally, I'd say yes, 7.2 is very old and they can always version pin.

[aik099]

@davedevelopment , then here are the next steps:

1. create another PR that will set a minimum compatible PHP version to PHP 7.2 (or even PHP 7.4)
2. make a release
3. rebase & merge this PR

.

[davedevelopment]

Opened #87

[txdFabio]

I've seen the 2.1.0 release which remove older php constraints, but - while it's merged to master - it doesn't include the implicit nullable fix, is there anything else we need to do?

[davedevelopment]

Generally I'd avoid tagging for every fix, but go on then...