Drop support for PHP <=7.3 #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes outdated PHP versions from the CI tests to drop support for PHP versions lower than 7.3.
- Removed PHP versions 5.3 through 7.3 from the workflow matrix
- Retained testing for PHP 7.4, 8.0, and 8.1
Files not reviewed (2)
- .travis.yml: Language not supported
- composer.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/tests.yml:8
- The diff removes PHP 7.3 from the test matrix, but the PR title indicates dropping support for PHP versions lower than 7.3. If PHP 7.3 should be retained as supported, please remove the deletion of the '7.3' entry; otherwise, update the PR title and description to reflect its removal.
- - '7.3'
aik099
approved these changes
Apr 29, 2025
Member
aik099
left a comment
aik099
left a comment
There was a problem hiding this comment.
I've updated your PR title (replaced <7.3 with <=7.3) as per Copilot review 😄 suggestions.
Otherwise, looks good.
Member
Author
|
@aik099 what are your feelings on versioning with regards to dropping support for PHP versions and major or minor bumps? I really don't care either way, I see both sides of the arguments... |
Member
|
Considering specifics of this project (assets are the same all the time and we're only fixing PHP version compatibility), then doing a 2.1.0 release would be enough. I'm also fine with the 3.0.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #85
There will be opportunities for further cleanup, but setting the requirements comes first.