-
Couldn't load subscription status.
- Fork 192
[docs] port to mkdocs #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @MihirJagtap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a significant overhaul of the project's documentation infrastructure, transitioning from Sphinx to MkDocs. The change aims to modernize the documentation's appearance, improve maintainability, and streamline the process of generating and presenting content, particularly for code examples and API references. This migration involved extensive file renaming, content adaptation to MkDocs syntax, and the introduction of new configuration and styling assets. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the documentation from Sphinx to MkDocs. The changes are extensive and well-executed for the most part, including new configuration files, updated scripts, and restructured markdown files. However, I've identified a few critical issues that could impact the correctness and completeness of the new documentation site. These include incorrect syntax for the documentation generation tool and missing content that was present in the previous version. Addressing these points will help ensure a successful migration.
| ```bash | ||
| bash examples/distill/Wan2.2-TI2V-5B-Diffusers/crush_smol/examples/distill/Wan2.2-TI2V-5B-Diffusers/crush_smol/ | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command appears to be incorrect. The path is duplicated and points to a directory instead of a script. Additionally, the instruction is for 'DMD-only distillation', but there doesn't seem to be a corresponding script in this example's directory. Please verify the correct command and script to run.
No description provided.