feat: sync infrastructure files from develop #712

MiguelLZPF · 2025-11-26T07:29:29Z

Description

Sync PR: Minimal infrastructure updates to align main branch with develop improvements.

Important: This PR was rebuilt using a clean slate approach to ensure zero unwanted regressions. Previous commits (8333f2b, cc937b9) contained unintended changes that have been removed.

What Changed

Only 2 files modified (down from 8 in previous version):

.github/workflows/README.md
- Moved from .github/README.md to .github/workflows/README.md
- Better organization for workflows documentation
.github/workflows/ats.publish.yml (4 specific fixes only):
- From commit e0c152e: Added endsWith() checks for release tags ending with '-ats'/'-ATS'
- From commit 7f34000: Changed npm publish access from 'restricted' to 'public' (required for scoped @hashgraph packages)
- Applied to both contracts and SDK job conditions

All 6 other workflow files remain 100% identical to main (no changes):

ats.release.yml
ats.test.yml
changeset-check.yml
mp.publish.yml
mp.release.yml
mp.test.yml

Why This Approach

Clean Slate Strategy:

Started with main branch baseline for all workflows
Applied ONLY 2 specific fixes from develop commits
Moved README to correct location
Result: Minimal, targeted changes with zero regressions

Regressions Prevented:

✅ No PGP signature removals
✅ No node version changes
✅ No error handling removals
✅ No syntax changes to other workflows

Verification

Alignment Status:

✅ Only ats.publish.yml modified with 2 specific fixes
✅ All other workflows identical to main (0 differences)
✅ README properly relocated
✅ Commit has DCO + PGP signature

Testing:

CI tests running automatically
All security checks passing
No code logic changes - only workflow configuration

Type of change

Refactor 🔧
Documentation update 📖

Checklist

Style Guidelines followed ✅
Documentation Updated 📚
Linters - No New Warnings ⚠️
No reduction of Coverage ✅

Part 1/2 of develop→main sync strategy

This PR: Infrastructure changes (CODEOWNERS-protected files)
PR feat: sync codebase from develop #713: Codebase changes (all other files)

Reviewers Required:

@hashgraph/platform-ci
@hashgraph/platform-ci-committers
@hashgraph/release-engineering-managers

Related PR: #713 (codebase sync)

hedera-eng-infrastructure · 2025-11-26T07:29:41Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Syncs all codebase changes from develop branch to main (excluding workflow files): - Smart contracts (packages/ats/contracts/) - SDK (packages/ats/sdk/) - Web application (apps/ats/web/) - Mass payout packages - Tests, documentation, configuration files Includes features from develop: - T-REX SDK enhancements - Bond coupon system improvements - UI/UX fixes and refactoring - Workspace dependency alignment - Version alignment to 1.17.0 - Scripts refactoring - Changesets implementation - Mass-payout build fixes Part 2/2 of develop→main sync (codebase changes). Workflow files are in PR #712. Signed-off-by: Miguel_LZPF <[email protected]>

…kflows Phase 1 alignment completed: - Removed 53 files that don't exist on develop: - Build artifacts (.solhint.json, functions.txt) - Misnamed contracts (totalBalancesStorageWrapper.sol, BondUSARead.sol) - TimeTravel test contracts (6 files) - Demo test files (3 files) - Unit test files (40 files) - Restored TotalBalancesStorageWrapper.sol from develop - Reverted .github/ workflow files to match main This ensures PR #713 only contains codebase changes, while workflow changes remain in PR #712. Signed-off-by: Miguel_LZPF <[email protected]>

This PR contains minimal infrastructure updates required to align main branch with develop branch improvements: Changes from commit e0c152e (release tag pattern fix): - Add endsWith() checks to release tag matching logic - Ensures tags ending with '-ats' or '-ATS' trigger workflows - Fixes both contracts and SDK job conditions in ats.publish.yml Changes from commit 7f34000 (npm publish access fix): - Change npm publish access from 'restricted' to 'public' - Required for scoped @hashgraph packages to publish correctly - Applied to both contracts and SDK publish steps Additional change: - Move workflows documentation from .github/README.md to .github/workflows/README.md for better organization All other workflow files remain identical to main branch, ensuring no unintended regressions. This is part 1/2 of the develop-to-main sync strategy (infrastructure changes only). Related: Part 2/2 is PR #713 (codebase changes) Signed-off-by: Miguel_LZPF <[email protected]>

gregscullard

LGTM

Update PR #712 branch to include changes from PR #713 (codebase sync) that was just merged to main. This brings the branch up to date with the current main branch state. Signed-off-by: Miguel_LZPF <[email protected]>

rbarker-dev

Minor changes needed.

.github/workflows/ats.publish.yml

.github/README.md

.github/workflows/README.md

Update PR #712 branch to include changes from PR #713 (codebase sync) that was just merged to main. This brings the branch up to date with the current main branch state. Signed-off-by: Miguel_LZPF <[email protected]>

MiguelLZPF · 2025-12-01T14:38:10Z

Thanks for the comments @rbarker-dev ! Should be all fixed now

rbarker-dev

LGTM

Brings workflow fixes from PR #712 and #713 into develop branch. Conflicts resolved: workflow files (main's version), contract/test files (develop's version). Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Miguel_LZPF <[email protected]>

Brings workflow fixes from PR #712 and #713 into develop branch. Conflicts resolved: workflow files (main's version), contract/test files (develop's version). Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Miguel_LZPF <[email protected]> Signed-off-by: Mario Francia <[email protected]>

Brings workflow fixes from PR #712 and #713 into develop branch. Conflicts resolved: workflow files (main's version), contract/test files (develop's version). Signed-off-by: Miguel_LZPF <[email protected]> Signed-off-by: Mario Francia <[email protected]>

MiguelLZPF requested review from a team as code owners November 26, 2025 07:29

MiguelLZPF requested a review from rbarker-dev November 26, 2025 07:29

MiguelLZPF self-assigned this Nov 26, 2025

MiguelLZPF marked this pull request as draft November 26, 2025 07:29

MiguelLZPF mentioned this pull request Nov 26, 2025

feat: sync codebase from develop #713

Merged

12 tasks

MiguelLZPF force-pushed the feat/infrastructure-sync-from-develop branch from cc937b9 to 284eb46 Compare November 26, 2025 14:36

MiguelLZPF marked this pull request as ready for review November 26, 2025 15:55

gregscullard previously approved these changes Nov 27, 2025

View reviewed changes

rbarker-dev requested changes Dec 1, 2025

View reviewed changes

chore: merge main into infrastructure sync branch

cd08da6

Update PR #712 branch to include changes from PR #713 (codebase sync) that was just merged to main. This brings the branch up to date with the current main branch state. Signed-off-by: Miguel_LZPF <[email protected]>

MiguelLZPF dismissed gregscullard’s stale review via cd08da6 December 1, 2025 14:35

MiguelLZPF force-pushed the feat/infrastructure-sync-from-develop branch from 41ab7ca to cd08da6 Compare December 1, 2025 14:35

MiguelLZPF requested review from gregscullard and rbarker-dev December 1, 2025 14:56

rbarker-dev approved these changes Dec 2, 2025

View reviewed changes

MiguelLZPF merged commit 46e2002 into main Dec 2, 2025
10 checks passed

MiguelLZPF deleted the feat/infrastructure-sync-from-develop branch December 2, 2025 15:05

themariofrancia pushed a commit that referenced this pull request Dec 10, 2025

feat: sync infrastructure files from develop (#712)

9f3b238

Signed-off-by: Miguel_LZPF <[email protected]>

themariofrancia pushed a commit that referenced this pull request Dec 10, 2025

feat: sync infrastructure files from develop (#712)

96b3a0b

Signed-off-by: Miguel_LZPF <[email protected]> Signed-off-by: Mario Francia <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: sync infrastructure files from develop #712

feat: sync infrastructure files from develop #712

MiguelLZPF commented Nov 26, 2025 •

edited

Loading

Uh oh!

hedera-eng-infrastructure commented Nov 26, 2025 •

edited

Loading

Uh oh!

gregscullard left a comment

Uh oh!

rbarker-dev left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelLZPF commented Dec 1, 2025

Uh oh!

rbarker-dev left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: sync infrastructure files from develop #712

feat: sync infrastructure files from develop #712

Conversation

MiguelLZPF commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What Changed

Why This Approach

Verification

Type of change

Checklist

Uh oh!

hedera-eng-infrastructure commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

gregscullard left a comment

Choose a reason for hiding this comment

Uh oh!

rbarker-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MiguelLZPF commented Dec 1, 2025

Uh oh!

rbarker-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MiguelLZPF commented Nov 26, 2025 •

edited

Loading

hedera-eng-infrastructure commented Nov 26, 2025 •

edited

Loading