Skip to content

Conversation

@MiguelLZPF
Copy link
Contributor

Description

Sync PR: Brings all codebase changes from develop to main (49 commits of feature work) to align both branches for upcoming releases.

Scope: This PR contains 622 files representing complete develop branch state to date, excluding CODEOWNERS-protected infrastructure files (which are in PR #712).

Key Features Included:

Smart Contracts (100+ files):

  • T-REX security token enhancements (ERC-3643 compliance)
  • Bond coupon system with corporate actions and automated scheduling
  • New facets: ERC20Votes, BondUSA, Equity/Bond TimeTravel variants
  • Enhanced deployment scripts and test infrastructure

SDK (25+ files):

  • Bond redemption and coupon query capabilities
  • Equity dividend queries
  • Request/response model improvements
  • Error handling alignment with contracts

Web Application (20+ files):

  • Bond and equity form refactoring
  • Role management with snapshot capabilities
  • UI/UX improvements and bug fixes
  • i18n translations updates

Additional:

  • Workspace dependency alignment (wildcard pattern)
  • Version alignment to 1.17.0 across all ATS packages
  • 12 changesets documenting feature improvements
  • Mass payout package updates
  • Fix: Added @nestjs/cli to mass-payout SDK devDependencies (required for build)

Why This PR:

  • Part 2/2 of develop→main full sync
  • Develop is the source of truth with 49 commits ahead of main
  • Enables upcoming release cycles with all feature work included

Type of change

  • New feature ✨
  • Bug fix 🐞
  • Refactor 🔧
  • Documentation update 📖

Testing

Automated Tests:

npm run ats:build   # All packages build successfully
npm run ats:test    # All tests pass

Coverage: Maintained across all changes (no reduction)

Manual Verification:

  • Smart contracts compile with Hardhat
  • SDK tests pass with Jest
  • Web application builds with Vite
  • All changesets validate correctly

Test Results

Node version:

  • 20
  • 22

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Related: This PR should merge in parallel with PR #712 (infrastructure sync). Both are required for complete develop→main alignment.

Post-Merge: After both PRs merge, develop will be fast-forward merged with main to complete the synchronization.

@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Nov 26, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@MiguelLZPF MiguelLZPF marked this pull request as draft November 26, 2025 07:47
@MiguelLZPF MiguelLZPF self-assigned this Nov 26, 2025
@MiguelLZPF MiguelLZPF force-pushed the feat/codebase-sync-from-develop branch 2 times, most recently from d7d0906 to d13b37c Compare November 26, 2025 11:23
Syncs all codebase changes from develop branch to main (excluding workflow files):
- Smart contracts (packages/ats/contracts/)
- SDK (packages/ats/sdk/)
- Web application (apps/ats/web/)
- Mass payout packages
- Tests, documentation, configuration files

Includes features from develop:
- T-REX SDK enhancements
- Bond coupon system improvements
- UI/UX fixes and refactoring
- Workspace dependency alignment
- Version alignment to 1.17.0
- Scripts refactoring
- Changesets implementation
- Mass-payout build fixes

Part 2/2 of develop→main sync (codebase changes).
Workflow files are in PR #712.

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF force-pushed the feat/codebase-sync-from-develop branch from d13b37c to fdc50e5 Compare November 26, 2025 12:10
…kflows

Phase 1 alignment completed:
- Removed 53 files that don't exist on develop:
  - Build artifacts (.solhint.json, functions.txt)
  - Misnamed contracts (totalBalancesStorageWrapper.sol, BondUSARead.sol)
  - TimeTravel test contracts (6 files)
  - Demo test files (3 files)
  - Unit test files (40 files)
- Restored TotalBalancesStorageWrapper.sol from develop
- Reverted .github/ workflow files to match main

This ensures PR #713 only contains codebase changes,
while workflow changes remain in PR #712.

Signed-off-by: Miguel_LZPF <[email protected]>
MiguelLZPF added a commit that referenced this pull request Nov 26, 2025
This PR contains minimal infrastructure updates required to align main
branch with develop branch improvements:

Changes from commit e0c152e (release tag pattern fix):
- Add endsWith() checks to release tag matching logic
- Ensures tags ending with '-ats' or '-ATS' trigger workflows
- Fixes both contracts and SDK job conditions in ats.publish.yml

Changes from commit 7f34000 (npm publish access fix):
- Change npm publish access from 'restricted' to 'public'
- Required for scoped @hashgraph packages to publish correctly
- Applied to both contracts and SDK publish steps

Additional change:
- Move workflows documentation from .github/README.md to
  .github/workflows/README.md for better organization

All other workflow files remain identical to main branch, ensuring no
unintended regressions. This is part 1/2 of the develop-to-main sync
strategy (infrastructure changes only).

Related: Part 2/2 is PR #713 (codebase changes)
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF marked this pull request as ready for review November 26, 2025 15:55
Copy link
Contributor

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelLZPF MiguelLZPF merged commit c748529 into main Nov 27, 2025
11 checks passed
@MiguelLZPF MiguelLZPF deleted the feat/codebase-sync-from-develop branch November 27, 2025 12:33
MiguelLZPF added a commit that referenced this pull request Nov 27, 2025
Update PR #712 branch to include changes from PR #713 (codebase sync)
that was just merged to main. This brings the branch up to date with
the current main branch state.

Signed-off-by: Miguel_LZPF <[email protected]>
MiguelLZPF added a commit that referenced this pull request Dec 1, 2025
Update PR #712 branch to include changes from PR #713 (codebase sync)
that was just merged to main. This brings the branch up to date with
the current main branch state.

Signed-off-by: Miguel_LZPF <[email protected]>
MiguelLZPF added a commit that referenced this pull request Dec 3, 2025
Brings workflow fixes from PR #712 and #713 into develop branch.
Conflicts resolved: workflow files (main's version), contract/test files (develop's version).

Signed-off-by: Miguel_LZPF <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 9, 2025
Brings workflow fixes from PR #712 and #713 into develop branch.
Conflicts resolved: workflow files (main's version), contract/test files (develop's version).

Signed-off-by: Miguel_LZPF <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
Brings workflow fixes from PR #712 and #713 into develop branch.
Conflicts resolved: workflow files (main's version), contract/test files (develop's version).

Signed-off-by: Miguel_LZPF <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
Brings workflow fixes from PR #712 and #713 into develop branch.
Conflicts resolved: workflow files (main's version), contract/test files (develop's version).

Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants