Skip to content

[Project Solar / Phase 1 / Cherry-pick] Updated prepublishOnly in package.json to use a custom script#3563

Merged
didoo merged 1 commit intomainfrom
project-solar/phase-1/HDS-6024/HDS-6029/check-dist-files-script
Feb 10, 2026
Merged

[Project Solar / Phase 1 / Cherry-pick] Updated prepublishOnly in package.json to use a custom script#3563
didoo merged 1 commit intomainfrom
project-solar/phase-1/HDS-6024/HDS-6029/check-dist-files-script

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Feb 6, 2026

📌 Summary

Small PR to cherry-pick from #3237 the implementation of a custom script to check that the correct CSS files are generated in the build step before proceeding with the publication of the package.

Note: these changes were first introduced/implemented in #3462

🛠️ Detailed description

In this PR I have:

  • updated prepublishOnly in package.json to use a custom script

I have tested the script by:

  • removing the file design-system-power-select-overrides.css from the dist folder
  • running the script pnpm test:dist-files → script threw an error
  • re-building the components dist (via pnpm build)
  • running the script pnpm test:dist-files → script silently succeeded

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-6028


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

- cherry picked from #3237
- previously implemented in #3462
@didoo didoo requested a review from alex-ju February 6, 2026 17:01
@didoo didoo requested a review from a team as a code owner February 6, 2026 17:01
@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Feb 6, 2026 5:01pm
hds-website Ready Ready Preview Feb 6, 2026 5:01pm

Request Review

@didoo
Copy link
Contributor Author

didoo commented Feb 10, 2026

@alex-ju I am going to merge this one, to reduce possibility of conflicts; when you're back from PTO can you review it anyway (since you implemented this script in the first place)? thanks

@didoo didoo merged commit 0027838 into main Feb 10, 2026
19 of 20 checks passed
@didoo didoo deleted the project-solar/phase-1/HDS-6024/HDS-6029/check-dist-files-script branch February 10, 2026 15:21
@alex-ju
Copy link
Member

alex-ju commented Feb 13, 2026

@alex-ju I am going to merge this one, to reduce possibility of conflicts; when you're back from PTO can you review it anyway (since you implemented this script in the first place)? thanks

Looks good! Thanks for the heads-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants