Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
45 tasks
shleewhite
approved these changes
Feb 6, 2026
Contributor
Author
|
@alex-ju I am going to merge this one, to reduce possibility of conflicts; when you're back from PTO can you review it anyway (since you implemented this script in the first place)? thanks |
Member
Looks good! Thanks for the heads-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Small PR to cherry-pick from #3237 the implementation of a custom script to check that the correct CSS files are generated in the
buildstep before proceeding with the publication of the package.Note: these changes were first introduced/implemented in #3462
🛠️ Detailed description
In this PR I have:
prepublishOnlyinpackage.jsonto use a custom scriptI have tested the script by:
design-system-power-select-overrides.cssfrom thedistfolderpnpm test:dist-files→ script threw an errordist(viapnpm build)pnpm test:dist-files→ script silently succeeded🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-6028
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.