Add List Resource Config Validation #1178
Conversation
| "An unexpected error was encountered when converting the configuration from the protocol type. "+ | ||
| "This is always an issue in terraform-plugin-framework used to implement the provider and should be reported to the provider developers.\n\n"+ | ||
| "Please report this to the provider developer:\n\n"+ | ||
| "Missing schema.", |
There was a problem hiding this comment.
💭 Here's a thought to consider – completely non-blocking for merging this PR.
While we're adding new kinds of schemas, I wonder if this diagnostic is precise enough to be actionable by a provider developer.
"Missing list resource schema for ``random_pet``" seems nice to have here. And also at odds with the universal message in fromproto6.Config().
So I'm curious how this diagnostic reads when it is rendered by the Terraform CLI and whether it includes precise context. If it's not precise, I suggest we adjust the Config diagnostic to be more flexible.
There was a problem hiding this comment.
FWIW, this error message is only for our team, and isn't actionable by the provider developer outside of reporting it to us:
terraform-plugin-framework/internal/fromproto5/config.go
Lines 25 to 26 in 3f40cbd
The only way we'd hit this error is if there was a bug in Terraform core
| "An unexpected error was encountered when converting the configuration from the protocol type. "+ | ||
| "This is always an issue in terraform-plugin-framework used to implement the provider and should be reported to the provider developers.\n\n"+ | ||
| "Please report this to the provider developer:\n\n"+ | ||
| "Missing schema.", |
There was a problem hiding this comment.
FWIW, this error message is only for our team, and isn't actionable by the provider developer outside of reporting it to us:
terraform-plugin-framework/internal/fromproto5/config.go
Lines 25 to 26 in 3f40cbd
The only way we'd hit this error is if there was a bug in Terraform core
| sort.Slice(got.ListResources, func(i int, j int) bool { | ||
| return got.ListResources[i].TypeName < got.ListResources[j].TypeName | ||
| }) |
There was a problem hiding this comment.
You might have noticed random CI failures for actions because I forgot to add this 😆
It'll be added in #1186, but in the mean time you can just re-run the CI and it'll eventually pass 😆
4 participants
Related Issue
Description
Added list resource validation and some missing tests
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No