Skip to content

querychecks: add tests #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 20, 2025
Merged

querychecks: add tests #553

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ccc33e8
update examplecloud resource/list resource and add test files for que…
stephybun Sep 19, 2025
45b23af
forgot one, oops
stephybun Sep 19, 2025
ccc4965
Saving my place
rainkwan Sep 25, 2025
1b91d14
Revert "Saving my place"
rainkwan Sep 25, 2025
84b0e71
Updating with correct packages
rainkwan Sep 25, 2025
ff103da
Merge branch 'main' into t/add-query-check-tests
rainkwan Oct 13, 2025
e7fe718
Almost passing all tests
rainkwan Oct 16, 2025
9af5b5b
Added missing copywrite
rainkwan Oct 16, 2025
25cbb89
remove early returns and retrieve resource schema in the providerserver
stephybun Oct 17, 2025
93f8293
Addressing PR comments
rainkwan Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 162 additions & 20 deletions helper/resource/query/examplecloud_list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ func examplecloudListResource() testprovider.ListResource {
Block: &tfprotov6.SchemaBlock{
Attributes: []*tfprotov6.SchemaAttribute{
{
Name: "id",
Name: "resource_group_name",
Type: tftypes.String,
Computed: true,
Required: true,
},
},
},
Expand All @@ -33,57 +33,199 @@ func examplecloudListResource() testprovider.ListResource {
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "somevalue"),
"id": tftypes.NewValue(tftypes.String, "foo/banane"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "banane"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 5),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue1"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "banane"),
},
)),
DisplayName: "banane",
})
push(list.ListResult{
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "foo/ananas"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "ananas"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 9000),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "ananas"),
},
)),
DisplayName: "ananas",
})
push(list.ListResult{
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "foo/kiwi"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "kiwi"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 88),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "kiwi"),
},
)),
DisplayName: "kiwi",
})
push(list.ListResult{
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "bar/papaya"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "banane"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 3),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue2"),
"location": tftypes.NewValue(tftypes.String, "westeurope2"),
"resource_group_name": tftypes.NewValue(tftypes.String, "bar"),
"name": tftypes.NewValue(tftypes.String, "papaya"),
},
)),
DisplayName: "papaya",
})
push(list.ListResult{
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "bar/birne"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "birne"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 8564),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"resource_group_name": tftypes.NewValue(tftypes.String, "bar"),
"name": tftypes.NewValue(tftypes.String, "birne"),
},
)),
DisplayName: "birne",
})
push(list.ListResult{
Resource: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "bar/kirsche"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "kirsche"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, 500),
},
)),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue3"),
"location": tftypes.NewValue(tftypes.String, "westeurope3"),
"resource_group_name": tftypes.NewValue(tftypes.String, "bar"),
"name": tftypes.NewValue(tftypes.String, "kirsche"),
},
)),
DisplayName: "kirsche",
})
},
},
Expand Down
78 changes: 46 additions & 32 deletions helper/resource/query/examplecloud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,83 +17,95 @@ func examplecloudResource() testprovider.Resource {
NewState: tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "somevalue"),
"id": tftypes.NewValue(tftypes.String, "foo/banana"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "banana"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, int64(5)),
},
),
NewIdentity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "somelocation"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "banana"),
},
)),
},
ReadResponse: &resource.ReadResponse{
NewState: tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "somevalue"),
"id": tftypes.NewValue(tftypes.String, "foo/banana"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "banana"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, int64(5)),
},
),
NewIdentity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "banana"),
},
)),
},
ImportStateResponse: &resource.ImportStateResponse{
State: tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"id": tftypes.String,
"location": tftypes.String,
"name": tftypes.String,
"resource_group_name": tftypes.String,
"instances": tftypes.Number,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "somevalue"),
"id": tftypes.NewValue(tftypes.String, "foo/banana"),
"location": tftypes.NewValue(tftypes.String, "westeurope"),
"name": tftypes.NewValue(tftypes.String, "banana"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"instances": tftypes.NewValue(tftypes.Number, int64(5)),
},
),
Identity: teststep.Pointer(tftypes.NewValue(
tftypes.Object{
AttributeTypes: map[string]tftypes.Type{
"id": tftypes.String,
"location": tftypes.String,
"resource_group_name": tftypes.String,
"name": tftypes.String,
},
},
map[string]tftypes.Value{
"id": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"location": tftypes.NewValue(tftypes.String, "westeurope/somevalue"),
"resource_group_name": tftypes.NewValue(tftypes.String, "foo"),
"name": tftypes.NewValue(tftypes.String, "banana"),
},
)),
},
Expand All @@ -104,6 +116,8 @@ func examplecloudResource() testprovider.Resource {
ComputedStringAttribute("id"),
RequiredStringAttribute("location"),
RequiredStringAttribute("name"),
RequiredStringAttribute("resource_group_name"),
OptionalNumberAttribute("instances"),
},
},
},
Expand All @@ -113,12 +127,12 @@ func examplecloudResource() testprovider.Resource {
Version: 1,
IdentityAttributes: []*tfprotov6.ResourceIdentitySchemaAttribute{
{
Name: "id",
Name: "resource_group_name",
Type: tftypes.String,
RequiredForImport: true,
},
{
Name: "location",
Name: "name",
Type: tftypes.String,
RequiredForImport: true,
},
Expand Down
Loading