Skip to content

Conversation

@stephybun
Copy link
Member

Description

This PR

  • updates the schema/attributes that the examplecloud resource and list resource returns
  • adds test files and test cases for the various query checks

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Copy link
Member Author

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing up these tests @rainkwan!

I left a few clean up related comments that I think would be good to have addressed, either in this PR or in a follow up. The TestExpectKnownValue_ValueIncorrect should be updated though to correctly test an incorrect value.

@rainkwan rainkwan marked this pull request as ready for review October 17, 2025 12:21
@rainkwan rainkwan requested a review from a team as a code owner October 17, 2025 12:21
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM 🚀

@rainkwan rainkwan merged commit 2d5ce8a into main Oct 20, 2025
43 checks passed
@rainkwan rainkwan deleted the t/add-query-check-tests branch October 20, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants