-
Notifications
You must be signed in to change notification settings - Fork 17
querychecks: add tests #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit ccc4965.
stephybun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing up these tests @rainkwan!
I left a few clean up related comments that I think would be good to have addressed, either in this PR or in a follow up. The TestExpectKnownValue_ValueIncorrect should be updated though to correctly test an incorrect value.
austinvalle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests LGTM 🚀
Description
This PR
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.