Skip to content

Conversation

@wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Jan 1, 2026

  • wip: Build ghcide with 9.14
  • plugins build with 9.14

Comment on lines +12 to +15
source-repository-package
type: git
location: https://github.com/snowleopard/alga
tag: d4e43fb42db05413459fb2df493361d5a666588a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Or is this just an allow-newer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I advice against using source-repository-package. I think it is a workaround when the package is not yet available on another repository such as Hackage. Can we update alga on Hackage instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, alga requires changes and can't be revised on hackage. While this is rather unfortunate, we will have to release with this source-repository-package stanza, as we are otherwise blocked for an unknown amount of time.

Copy link
Member

@Kleidukos Kleidukos Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fendor It's perfectly fine to vendor the patched alga in the HLS tree for the time being and remove it after the fix has been released. This allows people to install HLS from its Hackage sdist without trouble. :)

description: "Cabal version"
required: false
default: "3.14.2.0"
default: "3.16.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be bumped to 3.16.1.0

@benz0li
Copy link

benz0li commented Jan 8, 2026

FYI Building HLS 2.12.0.0 using GHC 9.12.3 fails, too:

Will this PR also fix this?

@fendor
Copy link
Collaborator

fendor commented Jan 8, 2026

@benz0li I don't think so, the failed CI jobs point to ghc-lib-parser being incompatible with ghc 9.12.3.

@dschrempf
Copy link
Collaborator

According to https://discourse.haskell.org/t/critical-code-generation-bug-with-ghc-9-12-3/13505 we should avoid using GHC 9.12.3 altogether. (Maybe irrelevant).

@benz0li
Copy link

benz0li commented Jan 8, 2026

@benz0li I don't think so, the failed CI jobs point to ghc-lib-parser being incompatible with ghc 9.12.3.

True. Then, I wonder why it picks ghc-lib-parser-9.12.2.20250421 when there is ghc-lib-parser-9.12.3.20251228 available.

@fendor
Copy link
Collaborator

fendor commented Jan 8, 2026

@benz0li Ah, perhaps the index-state needs to be updated? That might be fixed by this PR.

@benz0li
Copy link

benz0li commented Jan 8, 2026

According to https://discourse.haskell.org/t/critical-code-generation-bug-with-ghc-9-12-3/13505 we should avoid using GHC 9.12.3 altogether. (Maybe irrelevant).

Cross reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants