fix: enhance SQL query name extraction in otel tracer and fallback#3277
Merged
fix: enhance SQL query name extraction in otel tracer and fallback#3277
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the OpenTelemetry span naming for pgx database queries by enabling SQL statement trimming in span names (WithTrimSQLInSpanName) and replacing the previous "UNKNOWN" fallback with a more descriptive one that uses the first 6 words of the SQL statement (uppercased).
Changes:
- Adds
otelpgx.WithTrimSQLInSpanName()to the OTel pgx tracer configuration. - Replaces the
"UNKNOWN"fallback insqlcSpanNamewith a call tofirstNWords(stmt, 6)for ad-hoc queries. - Introduces a new
firstNWordshelper that extracts and uppercases the first N words from a string.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
Benchmark resultsCompared against |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
mrkaye97
approved these changes
Mar 17, 2026
…-name-and-fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the sql name trunc by default and falls back to meaningful text when no name is present.
Type of change