Skip to content

Implement adjustments for Java 11#14

Open
TobiasNx wants to merge 10 commits intomainfrom
updateToJava11
Open

Implement adjustments for Java 11#14
TobiasNx wants to merge 10 commits intomainfrom
updateToJava11

Conversation

@TobiasNx
Copy link

Also updating metafacture to 11

Also updating metafacture to 11
@TobiasNx TobiasNx changed the title Set up using RPPD data in rpb repo as index data (RPB-38) Implement adjustments for Java 11 Feb 19, 2026
@TobiasNx
Copy link
Author

@fsteeg hier auch @acka47 als functional reviewer?

Comment on lines 151 to 165
Copy link
Author

@TobiasNx TobiasNx Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. Java 11 did not compile because it reported the following:

method javax.xml.stream.XMLEventFactory.createStartElement(javax.ml.namespace.QName,java.util.Iterator<? extends javax.xml.stream.events.Attribute>,java.util.Iterator<? extends javax.xml.stream.events.Namespace>) is not applicable

refering to line 165 with the change in 151 it worked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code is originally from lobid-gnd (there, it works with Java 11 in your PR?), and is not actually used for rppd. I think all the Convert* classes could be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to remove the Convert* classes: f0bae2f

The result runs into errors. Maybe you could have a look @fsteeg in spare time. Not super urgent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like the removal is the problem. IndexAppTest is failing, getting 0 hits.

I think the point to start investigating is why it worked in lobid-gnd, but not here. Should be the same, since this is a fork of lobid-gnd. I think you should look into the details of what you did there and here, and try to do it the same way.

(I'm also currently not getting either this or lobid-gnd to properly run in VS code, with module-related errors)

@TobiasNx TobiasNx mentioned this pull request Feb 20, 2026
@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants