Fix incorrect test and clean up edge case for Vector Index #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1293 +/- ##
==========================================
- Coverage 91.62% 91.62% -0.01%
==========================================
Files 42 42
Lines 9684 9678 -6
Branches 1963 1962 -1
==========================================
- Hits 8873 8867 -6
Misses 523 523
Partials 288 288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Review Notes: This should be ready to go, but possible coverage may need an extra test to get it covered 100% |
rly
changed the title
rly
reviewed
Oct 4, 2025
| columns=[VectorData(name='p1', description='p1', data=np.arange(3)), dtr_p1, vi_dtr_p1]) | ||
| # Super-parent table | ||
| dtr_sp = DynamicTableRegion(name='sl1', description='sl1', data=np.arange(4), table=p1) | ||
| dtr_sp = DynamicTableRegion(name='sl1', description='sl1', data=np.arange(3), table=p1) |
There was a problem hiding this comment.
The previous data range was invalid because the target table only has 3 rows. This was causing an IndexError in VectorIndex.get.
There was a problem hiding this comment.
@oruebel since you set up this test originally, please confirm that I am not missing something
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1249
How to test the behavior?
Checklist
CHANGELOG.mdwith your changes?