[herd,asl] Use a custom transitive closure in asl.cat#1690
Merged
HadrienRenaud merged 3 commits intoherd:masterfrom Feb 6, 2026
Merged
[herd,asl] Use a custom transitive closure in asl.cat#1690HadrienRenaud merged 3 commits intoherd:masterfrom
HadrienRenaud merged 3 commits intoherd:masterfrom
Conversation
This was referenced Feb 3, 2026
maranget
approved these changes
Feb 5, 2026
Member
maranget
left a comment
maranget
left a comment
There was a problem hiding this comment.
Thanks @HadrienRenaud. A simple and rewarding optimisation with no semantic risk. Well done.
HadrienRenaud
added a commit
to HadrienRenaud/herdtools7
that referenced
this pull request
Feb 5, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
HadrienRenaud
added a commit
to HadrienRenaud/herdtools7
that referenced
this pull request
Feb 6, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
HadrienRenaud
added a commit
to HadrienRenaud/herdtools7
that referenced
this pull request
Feb 9, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
HadrienRenaud
added a commit
to HadrienRenaud/herdtools7
that referenced
this pull request
Feb 9, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
maranget
added a commit
that referenced
this pull request
Feb 12, 2026
Slight generalisation of PR #1690: keep relations in map (set of neighbourgs) during sequence interpretation.
HadrienRenaud
added a commit
to HadrienRenaud/herdtools7
that referenced
this pull request
Feb 12, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
RaghavRoy145
pushed a commit
to RaghavRoy145/herdtools7
that referenced
this pull request
Feb 21, 2026
By filtering on the map representation instead of the set representation, we gain a 68% speedup on `make test-asl-vmsa`. #### Performance Comparing the output of `make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl` on both master and current, we have: | branch | time output | |--------:|--------| | `master` | `410.46s user 10.51s system 680% cpu 1:01.88 total` | | `new-transitive-closure` | `193.03s user 7.33s system 654% cpu 30.601 total` |
RaghavRoy145
pushed a commit
to RaghavRoy145/herdtools7
that referenced
this pull request
Feb 21, 2026
Performance improvements on top of new-transitive-closure (herd#1690) make build && time make test-asl-vmsa test-aarch64-asl cata-test-asl Before 194.60s user 7.40s system 667% cpu 30.259 total After 161.49s user 7.31s system 690% cpu 24.434 total
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By filtering on the map representation instead of the set representation, we gain a 68% speedup on
make test-asl-vmsa.The commits begin by introducing a new primitive
inter_transitive3that is in the end removed. I'm planning on squashing the commits so it will disappear from git history, but until it is approved I'm keeping this as a useful testing tool.Performance
Comparing the output of
make build && time make test-asl-vmsa test-aarch64-asl cata-test-aslon both master and current, we have:master410.46s user 10.51s system 680% cpu 1:01.88 totalnew-transitive-closure193.03s user 7.33s system 654% cpu 30.601 total