Fix RPCs via REST connections to Nakama outside of web#169
Open
ilmalte wants to merge 1 commit intoheroiclabs:mainfrom
Open
Fix RPCs via REST connections to Nakama outside of web#169ilmalte wants to merge 1 commit intoheroiclabs:mainfrom
ilmalte wants to merge 1 commit intoheroiclabs:mainfrom
Conversation
Refactor RPC payload handling and remove unused code. In details: - Updated the NakamaGrpcClient to directly use the payload without preparation (payload encoding is only needed for REST and not for gRPC). - Simplified the preparePayload function to always encode the payload as JSON. - Deleted platform-specific stub files/logic (no longer used). - Added tests (covers issue heroiclabs#167)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor RPC payload handling and remove unused code.
In details: