fix: source_ips property is optional in firewall rule #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 64 64
Lines 2978 2980 +2
=======================================
+ Hits 2875 2877 +2
Misses 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jooola
pushed a commit
that referenced
this pull request
Oct 7, 2025
<!-- section-start changelog --> ### DNS API Beta This release adds support for the new [DNS API](https://docs.hetzner.cloud/reference/cloud#dns). The DNS API is currently in **beta**, which will likely end on 10 November 2025. After the beta ended, it will no longer be possible to create new zones in the old DNS system. See the [DNS Beta FAQ](https://docs.hetzner.com/networking/dns/faq/beta) for more details. Future minor releases of this project may include breaking changes for features that are related to the DNS API. See the [DNS API Beta changelog](https://docs.hetzner.cloud/changelog#2025-10-07-dns-beta) for more details. **Examples** ```py resp = client.zones.create( name="example.com", mode="primary", labels={"key": "value"}, rrsets=[ ZoneRRSet( name="@", type="A", records=[ ZoneRecord(value="201.180.75.2", comment="server1") ], ) ], ) resp.action.wait_until_finished() zone = resp.zone ``` ### Features - add new `ip_range` param to load balancer `attach_to_network` (#562) - add new `ip_range` param to server `attach_to_network` (#561) - support the new DNS API (#568) ### Bug Fixes - source_ips property is optional in firewall rule (#567) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ### DNS API Beta This release adds support for the new [DNS API](https://docs.hetzner.cloud/reference/cloud#dns). The DNS API is currently in **beta**, which will likely end on 10 November 2025. After the beta ended, it will no longer be possible to create new zones in the old DNS system. See the [DNS Beta FAQ](https://docs.hetzner.com/networking/dns/faq/beta) for more details. Future minor releases of this project may include breaking changes for features that are related to the DNS API. See the [DNS API Beta changelog](https://docs.hetzner.cloud/changelog#2025-10-07-dns-beta) for more details. **Examples** ```py resp = client.zones.create( name="example.com", mode="primary", labels={"key": "value"}, rrsets=[ ZoneRRSet( name="@", type="A", records=[ ZoneRecord(value="201.180.75.2", comment="server1") ], ) ], ) resp.action.wait_until_finished() zone = resp.zone ``` ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source IPs are only required if the direction is
in. Since we leave the API validate the data send, we must mark the source_ips property as optional.