Skip to content

fix: source_ips property is optional in firewall rule #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jooola merged 1 commit into from
Oct 6, 2025
Merged

fix: source_ips property is optional in firewall rule #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hcloud/firewalls/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,15 @@ def __init__(
self,
direction: str,
protocol: str,
source_ips: list[str],
source_ips: list[str] | None = None,
port: str | None = None,
destination_ips: list[str] | None = None,
description: str | None = None,
):
self.direction = direction
self.port = port
self.protocol = protocol
self.source_ips = source_ips
self.source_ips = source_ips or []
self.destination_ips = destination_ips or []
self.description = description

Expand All @@ -116,8 +116,9 @@ def to_payload(self) -> dict[str, Any]:
payload: dict[str, Any] = {
"direction": self.direction,
"protocol": self.protocol,
"source_ips": self.source_ips,
}
if len(self.source_ips) > 0:
payload["source_ips"] = self.source_ips
if len(self.destination_ips) > 0:
payload["destination_ips"] = self.destination_ips
if self.port is not None:
Expand Down