HHH-19445 ProcedureCall should accept BindableType, not BasicTypeReference #10131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebersole This look reasonable to you? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| getTypeConfiguration().getBasicTypeRegistry().resolve( typeReference ); | ||
| if ( basicType == null ) { | ||
| throw new IllegalArgumentException( "Could not resolve a BasicType for the java type: " + typeReference.getName() ); | ||
| public ProcedureCall markAsFunctionCall(BindableType<?> typeReference) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
and improve Javadoc
but mark it @Incubating, because it's very unclear we even need this interface
| } | ||
| else { | ||
| //noinspection resource | ||
| markAsFunctionCall( Integer.parseInt( value.toString() ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19445