HHH-19396 cannot select the same column twice with different aliases while using cte #10158
+125
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cigaly
changed the title
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
5126bf6 to
8b3f32e
Compare
|
Previous change was always setting |
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
8b3f32e to
38b7ede
Compare
mbellade
reviewed
May 28, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/internal/ConcreteSqmSelectQueryPlan.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
6a83ba0 to
9a986df
Compare
mbellade
reviewed
Jun 13, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
9a986df to
9429487
Compare
mbellade
reviewed
Jun 16, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
2 times, most recently
from
c1d91ce to
af39a76
Compare
mbellade
reviewed
Jun 17, 2025
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/query/sqm/tuple/internal/AnonymousTupleType.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
af39a76 to
9ff416f
Compare
mbellade
reviewed
Jun 17, 2025
...re/src/test/java/org/hibernate/orm/test/subquery/MultipleIdenticalColumnsInSubqueryTest.java
Outdated
Show resolved
Hide resolved
…wice in same (sub)query
…mporary tables and subqueries
Selection items representing same column in (sub)query will be represented with single instance, this will hide real alias
cigaly
force-pushed
the
HHH-19396-Cannot_select_the_same_column_twice_with_different_aliases_while_using_CTE
branch
from
9ff416f to
29eb98b
Compare
|
@mbellade Should I backport this to 6.6? |
|
@cigaly sure you can try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19396
When creating
SqlAstQueryPartProcessingStateImplin methodorg.hibernate.query.sqm.sql.BaseSqmToSqlAstConverter#visitQuerySpecparameterdeduplicateSelectionItemsmust be set tofalse(see comment in moved code block)When
selectStatementcontains same column more than once in methodorg.hibernate.query.sqm.tree.cte.SqmCteTable#createStatementTable,SqmCteTableconstructor will be unable to properly resolve aliases. To prevent this alias in select clause selection should be used if exist, one from selectable node should be used otherwise.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19396