HHH-19549 Hibernate Processor: When embeddable is annotated by @Access enclosing element must not change access type #10349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cigaly
force-pushed
the
HHH-19549-Enclosing_element_must_not_change_access_type_of_embeddable_annotated_with_@Access
branch
2 times, most recently
from
854098d to
992ddc8
Compare
gavinking
approved these changes
Jul 19, 2025
There was a problem hiding this comment.
@cigaly I must apologize for taking so long to review this.
This fix looks good to me.
But since I took so long to review this, it looks like changes to the testing framework have broken your test. This is completely my fault.
If you can fix the test, I promise I will merge the PR immediately.
Really sorry about that.
...el-generator/src/test/java/org/hibernate/processor/test/embeddable/ForcedAccessTypeTest.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-19549-Enclosing_element_must_not_change_access_type_of_embeddable_annotated_with_@Access
branch
from
992ddc8 to
6cbbf38
Compare
|
Merged! Thanks mate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19549
Always use access type specified when
@Accessannotation is present on embeddable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.