-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19629 Hibernate Processor may fail when repository method parameter has more than one annotation (e.g. multiple constraints) / HHH-19630 Hibernate Processor may fail if the return type is a single entity and annotated with multiple annotations #10595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19629 Hibernate Processor may fail when repository method parameter has more than one annotation (e.g. multiple constraints) / HHH-19630 Hibernate Processor may fail if the return type is a single entity and annotated with multiple annotations #10595
Conversation
|
It is working, with that comment that parameter will be annotated with two |
|
And if you really want some nitpicking, maybe you can (in into else branch (when type is |
f4a1451 to
774bbfb
Compare
...tamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java
Outdated
Show resolved
Hide resolved
774bbfb to
c345a55
Compare
...tamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java
Show resolved
Hide resolved
...tamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java
Show resolved
Hide resolved
|
Hey @marko-bekhta, do you think you can find the time to wrap this up? :) |
c345a55 to
9ebeb5d
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are tests, they're passing, and all comments have been addressed. Let's merge :) Thank you!
|
Backporting here: #11072 |
https://hibernate.atlassian.net/browse/HHH-19629
https://hibernate.atlassian.net/browse/HHH-19630
cc: @cigaly
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.