[7.1] Backport: HHH-19629 Hibernate Processor may fail when repository method parameter has more than one annotation (e.g. multiple constraints) / HHH-19630 Hibernate Processor may fail if the return type is a single entity and annotated with multiple annotations

[yrodiere]

https://hibernate.atlassian.net/browse/HHH-19629
https://hibernate.atlassian.net/browse/HHH-19630

Backport of #10595

[hibernate-github-bot]

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

[yrodiere]

The benefit/risk ratio of backporting this seems reasonable, WDYT @mbellade ?

[mbellade]

+1, the change seems pretty straightforward

[yrodiere]

Okay, plenty of failures... but:

1. The Quarkus run seems to be failing because we haven't merged Use dev services instead of maven docker plugin for Hibernate Search tests quarkusio/quarkus#48512 yet (:/)
2. TCK failures are the same ones as on the 7.1 branch: https://ci.hibernate.org/job/hibernate-orm-tck-3.2/job/7.1/34/console

Sybase failures are suspicious but ring a bell: https://ci.hibernate.org/job/hibernate-orm-pipeline/job/PR-11072/1/testReport/org.hibernate.orm.test.query.hql/LiteralTests/Build___sybase_jconn___Test___testEnumLiteralInPredicate_SessionFactoryScope_/

I'll try to have a look...

---

Regarding continuous improvement...

For 1 I guess we'd need someone to find time to refresh the PR and get it merged + backported. Marko is likely busy though.

For 2 there is most likely a pending Jakarta Persistence challenge, but I'll check.

[yrodiere]

Sybase failures are suspicious but ring a bell: https://ci.hibernate.org/job/hibernate-orm-pipeline/job/PR-11072/1/testReport/org.hibernate.orm.test.query.hql/LiteralTests/Build___sybase_jconn___Test___testEnumLiteralInPredicate_SessionFactoryScope_/

I'll try to have a look...

They're flaky: https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/Sybase/near/525683643

So, only false positives. I'll merge.

[marko-bekhta]

For 1 I guess we'd need someone to find time to refresh the PR and get it merged + backported

mm there's a bit more to it ... we need to be able to start multiple ES services for integration tests to be able to switch to dev services, and that means.. we should start with a named ES clients so that we can have multiple configs, then update the ES dev service to be able to start multiple instances, and then we can refresh the PR 😕
It's on todo ... but not yet the first line 🫣 🙁

[yrodiere]

For 1 I guess we'd need someone to find time to refresh the PR and get it merged + backported

mm there's a bit more to it ... we need to be able to start multiple ES services for integration tests to be able to switch to dev services, and that means.. we should start with a named ES clients so that we can have multiple configs, then update the ES dev service to be able to start multiple instances, and then we can refresh the PR 😕 It's on todo ... but not yet the first line 🫣 🙁

Can't you keep the maven-docker-plugin just for the extra containers?

[marko-bekhta]

I think then the "original" problem would still be there, and the plugin will be trying to manage the instances started by devservices 😔