HHH-18684 : If no @AnyDiscriminatorValue is returned, the entity name is used as the discriminator value. #9037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is used as the discriminator value.
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
boutss
changed the title
sebersole
reviewed
Oct 10, 2024
| final AnyType anyType = any.getType(); | ||
| final MetaType metaType = (MetaType) anyType.getDiscriminatorType(); | ||
| final Object discriminatorValue = metaType.getEntityNameToDiscriminatorValueMap().get( ownerPersister.getEntityName() ); | ||
| Object discriminatorValue = metaType.resolveDiscriminatorValue( ownerPersister.getEntityName() ); |
Member
There was a problem hiding this comment.
Please add the final back to match the rest of the code.
Suggested change
| Object discriminatorValue = metaType.resolveDiscriminatorValue( ownerPersister.getEntityName() ); | |
| final Object discriminatorValue = metaType.resolveDiscriminatorValue( ownerPersister.getEntityName() ); |
Member
There was a problem hiding this comment.
Actually, as we discussed on Zulip, I think this shoud pass in the persister rather than "just" the name. That would open up the possibility for the other things we discussed (short name, etc).
… is used as the discriminator value. -> Pass in the persister rather than "just" the name
Member
|
https://hibernate.atlassian.net/browse/HHH-18684 was closed with an indication that the problem was fixed in https://hibernate.atlassian.net/browse/HHH-18728. So, I'm going to close this PR. @boutss feel free to ping me if you think there is a mistake! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For complete the PR : HHH-15722 : @onetomany mappedBy with a @Any
It is proposed to add this feature :
If no @AnyDiscriminatorValue is returned, the entity name is used as the discriminator value.
This follows the discussions we had on Zulip.
https://hibernate.atlassian.net/browse/HHH-18684