cleanups around QueryTimeoutException and LockTimeoutException #9948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
from
4b1adcd to
4a23be7
Compare
gavinking
changed the title
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
2 times, most recently
from
270e7a1 to
9bfaeec
Compare
…res and h2 this is perhaps not *perfectly* correct for Postgres, but I believe it's good enough for our purposes (this error code can occur in some other situations, but they are very unlikely to affect us, it seems to me)
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
from
9bfaeec to
89b01c8
Compare
- PessimisticLockException dupes the role of LockAcquisitionException - We should not have database-specific codes on SQLStateConversionDelegate - throw LAE instead of PLE on MySQL and Maria
we don't have this for the other dialects, even though they all behave similarly
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
from
89b01c8 to
fa25af2
Compare
there's nothing I hate more than tests for log messages! Log messages are not part of the specified behavior of the library, and so they can't have tests. Your program should never depend on the behavior of the log messages written by Hibernate.
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
from
fa25af2 to
a85ea95
Compare
gavinking
force-pushed
the
mysql-maria-query-timeout
branch
from
ebf8859 to
4e70744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.