Skip to content

docs: Update documentation comments in FileUpdateTransaction.h#1210

Merged
rwalworth merged 4 commits intohiero-ledger:mainfrom
freya-docs:improve-doc-clarity
Mar 10, 2026
Merged

docs: Update documentation comments in FileUpdateTransaction.h#1210
rwalworth merged 4 commits intohiero-ledger:mainfrom
freya-docs:improve-doc-clarity

Conversation

@freya-docs
Copy link
Copy Markdown
Contributor

Description:

This PR updates documentation comments for clarity in FileUpdateTransaction.h

Related issue(s):

Fixes #1166

Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
@freya-docs freya-docs requested review from a team as code owners March 9, 2026 18:01
@freya-docs freya-docs requested a review from gsstoykov March 9, 2026 18:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Hi @freya-docs 👋, thank you for submitting this PR!
I'm your PR Helper Bot and I'll be keeping track of your PR's
status to help you get it approved and merged.

This comment will stay updated as you make changes.
Here's where things stand:


PR Checks

DCO Sign-off -- The following commits are missing the required DCO sign-off:

  • 4392937 Merge branch 'hiero-ledger:main' into improve-doc-clarity

Please add Signed-off-by: Your Name <email> to each commit (e.g. git commit -s). See the Signing Guide.


GPG Signature -- All commits have verified GPG signatures.


Merge Conflicts -- No merge conflicts detected.


Issue Link -- Linked to #1166 (assigned to you).


All checks must pass before this PR can be reviewed.

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Mar 9, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @freya-docs! The setContents and setFileMemo updates look good. I left a couple of comments below that need to be addressed before we can merge. Let me know if you have any questions!

@rwalworth rwalworth added status: needs revision A pull request that requires changes before merge and removed status: needs review The pull request is ready for maintainer review labels Mar 9, 2026
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
@rwalworth rwalworth added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 10, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @freya-docs! Running the workflows now and will merge once they complete.

@rwalworth rwalworth merged commit 151e142 into hiero-ledger:main Mar 10, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Improve documentation clarity for FileUpdateTransaction setter methods

2 participants