Skip to content

Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1230

Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom
ak004:fix-extractSignatureBytes
Mar 16, 2026
Merged

Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1230
rwalworth merged 1 commit intohiero-ledger:mainfrom
ak004:fix-extractSignatureBytes

Conversation

@ak004
Copy link
Copy Markdown
Contributor

@ak004 ak004 commented Mar 14, 2026

Description

Refactor the extractSignatureBytes helper to use the existing internal::Utilities::stringToByteVector() function and add a trailing newline to TransactionUnitTests.cc for POSIX compliance.

Changes:

  • Refactor extractSignatureBytes to use stringToByteVector()
  • Add trailing newline to TransactionUnitTests.cc

Related issue(s)

Fixes #1227

Notes for reviewer

  • No functional changes; behavior remains identical
  • Changes are limited to helper function and test file formatting

Checklist

  • Documented (code comments already updated)
  • Tested (existing unit tests pass)

@ak004 ak004 requested review from a team as code owners March 14, 2026 08:59
@ak004 ak004 requested a review from gsstoykov March 14, 2026 08:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026

Hey @ak004 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1227 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs revision A pull request that requires changes before merge label Mar 14, 2026
…iling newline

Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
@ak004 ak004 force-pushed the fix-extractSignatureBytes branch from 260ed02 to 6bd1872 Compare March 14, 2026 09:07
@github-actions github-actions bot added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 14, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The refactored extractSignatureBytes looks clean - it's consistent with how the rest of the file uses stringToByteVector, and the early-return structure is a nice improvement over the pointer approach. Trailing newline fix is good too.

Running the workflows now and will get this merged once they pass.

Congratulations on your first contribution to the Hiero C++ SDK @ak004! 🎉 I noticed you worked through a signing issue on your first attempt - that's totally normal, and you handled it well. Welcome to the project, and don't hesitate to reach out if you have questions on future contributions!

@rwalworth rwalworth merged commit 60daeb7 into hiero-ledger:main Mar 16, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 16, 2026
@ak004 ak004 deleted the fix-extractSignatureBytes branch March 17, 2026 05:45
@ak004
Copy link
Copy Markdown
Contributor Author

ak004 commented Mar 17, 2026

Thanks, I really appreciate it! Glad everything looks good.

And yeah, the signing part took me a minute 😄 — but I’m excited to keep contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: use stringToByteVector utility in extractSignatureBytes

2 participants