Refactor: extractSignatureBytes to use stringToByteVector and add tra…#1230
Conversation
|
Hey @ak004 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1227 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
…iling newline Signed-off-by: Mascud Muse Hassan <mascuudmusse44@gmail.com>
260ed02 to
6bd1872
Compare
rwalworth
left a comment
There was a problem hiding this comment.
LGTM! The refactored extractSignatureBytes looks clean - it's consistent with how the rest of the file uses stringToByteVector, and the early-return structure is a nice improvement over the pointer approach. Trailing newline fix is good too.
Running the workflows now and will get this merged once they pass.
Congratulations on your first contribution to the Hiero C++ SDK @ak004! 🎉 I noticed you worked through a signing issue on your first attempt - that's totally normal, and you handled it well. Welcome to the project, and don't hesitate to reach out if you have questions on future contributions!
|
Thanks, I really appreciate it! Glad everything looks good. And yeah, the signing part took me a minute 😄 — but I’m excited to keep contributing! |
Description
Refactor the
extractSignatureByteshelper to use the existinginternal::Utilities::stringToByteVector()function and add a trailing newline toTransactionUnitTests.ccfor POSIX compliance.Changes:
extractSignatureBytesto usestringToByteVector()TransactionUnitTests.ccRelated issue(s)
Fixes #1227
Notes for reviewer
Checklist