feat: Add /unassign command to allow contributors to unassign themselves#1246
Conversation
|
Hey @darshit2308 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1239 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
Signed-off-by: darshit2308 <darshit2308@gmail.com>
fd8acfb to
eb5d6e8
Compare
rwalworth
left a comment
There was a problem hiding this comment.
LGTM - clean, well-structured implementation that follows the existing patterns nicely. All the requirements from #1239 are covered (authorization gates, edge cases, removeAssignees helper, file structure, welcome comment update) and the test suite is thorough.
A few overall formatting items to clean up:
- Several files are missing the trailing newline at end of file (
bot-on-comment.js,unassign.js,unassign-comments.js,test-assign-bot.js,test-unassign-bot.js). Note thatbot-on-comment.jsandtest-assign-bot.jspreviously had trailing newlines - please restore those, and add them to the new files as well. - There's trailing whitespace on a few lines (
bot-on-comment.jslines 12 and 36,unassign.jsline 89,test-unassign-bot.jsline 13). A quick pass should catch these.
I left a couple more notes below - nothing blocking. Running workflows now and will merge once they pass!
Congratulations on your first contribution to the Hiero C++ SDK @darshit2308! 🎉 Thank you for taking the time to contribute!
Description:
Add support for the
/unassigncommand to allow contributors to drop issues they no longer have bandwidth for, reducing manual maintainer overhead.removeAssigneeshelper tohelpers/api.js/unassigncore logic (commands/unassign.js) validating issue state, authorization, and label reversioncommands/unassign-comments.js)/assignwelcome comment to inform users about the new/unassignfeature/unassignroute into the comment event dispatcher (bot-on-comment.js)Related issue(s):
Fixes #1239
Notes for reviewer:
test-unassign-bot.jssuite that mirrors the existing custom mock framework.Checklist