fix: reduce notification spam by skipping advanced check job on non-advanced issues#1580
Conversation
|
Hi, this is WorkflowBot.
|
WalkthroughAdds a Filter step that sets Changes
Sequence Diagram(s)sequenceDiagram
participant GH_Event as GitHub Event
participant Runner as Actions Runner
participant Filter as Filter Step
participant Checkout as actions/checkout
participant Script as bot-advanced-check.sh
GH_Event->>Runner: trigger workflow (issues: assigned/labeled, etc.)
Runner->>Filter: evaluate event, set should_run / skip reason
alt should_run == 'true'
Runner->>Checkout: conditional sparse-checkout (includes .github/scripts)
Runner->>Script: run `./.github/scripts/bot-advanced-check.sh`
Script-->>Runner: emit results/logs
else should_run == 'false'
Filter-->>Runner: output skip reason
Runner->>Runner: Log skip reason (no advanced checks run)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
042ff00 to
2b25213
Compare
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
|
@exploreriii @MonaaEid I followed the project guidelines and implemented the fix using a native job-level |
MonaaEid
left a comment
There was a problem hiding this comment.
I think it still has the same skipped status
what do you think?
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
…omment for accurate behavior Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
exploreriii
left a comment
There was a problem hiding this comment.
Hi @gangulysiddhartha22-cmyk could you test this on a fork please? we have a docuemnt testing_forks.md
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
|
@exploreriii -Tested the ready for review |
rwalworth
left a comment
There was a problem hiding this comment.
LGTM, recommend merge @exploreriii
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1580 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 140 140
Lines 8765 8765
=======================================
Hits 8142 8142
Misses 623 623 🚀 New features to boost your workflow:
|
|
Thank you so much everyone! |
…dvanced issues (hiero-ledger#1580) Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com> Signed-off-by: AkshayKumarSahu <your_verified_email>
Description:
Reduces notification spam from the advanced qualification check bot by skipping the entire workflow job on non-advanced issues and irrelevant events.
Related issue(s):
Fixes #1517
Notes for reviewer:
Test on a non-advanced issue: workflow should show as "Skipped"
No changes to bot-advanced-check.sh — both files remain.
Checklist