Skip to content

fix: reduce notification spam by skipping advanced check job on non-advanced issues#1580

Merged
exploreriii merged 6 commits intohiero-ledger:mainfrom
gangulysiddhartha22-cmyk:fix/bot-advanced-check-spam
Jan 25, 2026
Merged

fix: reduce notification spam by skipping advanced check job on non-advanced issues#1580
exploreriii merged 6 commits intohiero-ledger:mainfrom
gangulysiddhartha22-cmyk:fix/bot-advanced-check-spam

Conversation

@gangulysiddhartha22-cmyk
Copy link
Contributor

Description:
Reduces notification spam from the advanced qualification check bot by skipping the entire workflow job on non-advanced issues and irrelevant events.

Related issue(s):

Fixes #1517

Notes for reviewer:
Test on a non-advanced issue: workflow should show as "Skipped"
No changes to bot-advanced-check.sh — both files remain.

Checklist

  • Tested (unit, integration, etc.)

@github-actions
Copy link

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@gangulysiddhartha22-cmyk gangulysiddhartha22-cmyk changed the title Fix advanced check email spam on non-advanced issues fix: reduce notification spam by skipping advanced check job on non-advanced issues Jan 24, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

Walkthrough

Adds a Filter step that sets should_run to gate the advanced qualification job so non-relevant events are skipped; makes checkout and subsequent steps conditional, updates sparse-checkout to include .github/scripts, removes workflow_dispatch and concurrency cancel-in-progress, and adds a Log skip reason step.

Changes

Cohort / File(s) Summary
GitHub Actions workflow
/.github/workflows/bot-advanced-check.yml
Removed workflow_dispatch; added a Filter step that outputs should_run and a Log skip reason; subsequent steps (checkout, verify, script) now run only when steps.filter.outputs.should_run == 'true'. Updated actions/checkout to conditional execution, multiline sparse-checkout including .github/scripts, set sparse-checkout-cone-mode: false, removed cancel-in-progress concurrency settings, and minor permission/format tweaks.
Changelog
CHANGELOG.md
Added Unreleased → Fixed: reduce notification spam by skipping the advanced qualification job for non-advanced issues (#1517).

Sequence Diagram(s)

sequenceDiagram
    participant GH_Event as GitHub Event
    participant Runner as Actions Runner
    participant Filter as Filter Step
    participant Checkout as actions/checkout
    participant Script as bot-advanced-check.sh

    GH_Event->>Runner: trigger workflow (issues: assigned/labeled, etc.)
    Runner->>Filter: evaluate event, set should_run / skip reason
    alt should_run == 'true'
        Runner->>Checkout: conditional sparse-checkout (includes .github/scripts)
        Runner->>Script: run `./.github/scripts/bot-advanced-check.sh`
        Script-->>Runner: emit results/logs
    else should_run == 'false'
        Filter-->>Runner: output skip reason
        Runner->>Runner: Log skip reason (no advanced checks run)
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: reducing notification spam by skipping the advanced check job on non-advanced issues, which matches the core objective of the PR.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of reducing notification spam and referencing the linked issue #1517.
Linked Issues check ✅ Passed The PR successfully addresses all coding objectives from issue #1517: implements workflow-level gating via an if condition to skip the job for non-advanced issues, prevents unnecessary notifications, modifies bot-advanced-check.yml appropriately, and includes a changelog entry.
Out of Scope Changes check ✅ Passed All changes are directly within scope: workflow file modifications to implement job-level gating, changelog update documenting the fix, and no changes to bot-advanced-check.sh script as noted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
@gangulysiddhartha22-cmyk
Copy link
Contributor Author

@exploreriii @MonaaEid I followed the project guidelines and implemented the fix using a native job-level if condition in the YAML file. No additional scripts were added. ready for review. Thanks!

Copy link
Contributor

@MonaaEid MonaaEid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it still has the same skipped status
what do you think?

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

…omment for accurate behavior

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
Copy link
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gangulysiddhartha22-cmyk could you test this on a fork please? we have a docuemnt testing_forks.md

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
@gangulysiddhartha22-cmyk
Copy link
Contributor Author

@exploreriii -Tested the PythonBot - Advanced Requirement Check workflow on my fork, success.
-update to actions/checkout@v6.0.1,

ready for review

Copy link

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, recommend merge @exploreriii

@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1580   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         140      140           
  Lines        8765     8765           
=======================================
  Hits         8142     8142           
  Misses        623      623           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@exploreriii exploreriii dismissed MonaaEid’s stale review January 25, 2026 19:37

changes satisfied

@exploreriii exploreriii merged commit 855cfc7 into hiero-ledger:main Jan 25, 2026
18 checks passed
@exploreriii
Copy link
Contributor

Thank you so much everyone!
Really really appreciate this!

@gangulysiddhartha22-cmyk gangulysiddhartha22-cmyk deleted the fix/bot-advanced-check-spam branch January 26, 2026 12:53
AkshayKumarSahu pushed a commit to AkshayKumarSahu/hiero-sdk-python that referenced this pull request Jan 29, 2026
…dvanced issues (hiero-ledger#1580)

Signed-off-by: Siddhartha Ganguly <gangulysiddhartha22@gmail.com>
Signed-off-by: AkshayKumarSahu <your_verified_email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Fix advanced requirement check emails when creating non-advanced issues

4 participants