-
-
Notifications
You must be signed in to change notification settings - Fork 34
Add support for loading resources from multiple locations #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: hishamco <[email protected]>
Co-authored-by: hishamco <[email protected]>
|
|
||
| public string ResourcesPath { get; } | ||
|
|
||
| public string[] AdditionalResourcesPaths { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot we could change ResourcesPath instead of introducing a new property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean changing ResourcesPath from a single string to a collection (like IList<string>), so users can specify multiple paths directly? That would be a breaking change for existing users since it changes the type. Could you clarify the preferred approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use string[] instead as the return type. Don't worry about the breaking change, this will be included as part of the 4.0.0 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot, apply the changes based on my above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed ResourcesPath from string to string[] in commit ec0bb44. Removed the separate AdditionalResourcesPaths property.
…pport Co-authored-by: hishamco <[email protected]>
Changes
ResourcesPathproperty tostring[]to support loading JSON localization resources from multiple directories.Changes
ResourcesPathfromstringtostring[](breaking change for v4.0.0)string[]of paths and search all locations for resourcesUsage
Resources are loaded in order: first path takes precedence on key conflicts.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.