-
-
Notifications
You must be signed in to change notification settings - Fork 34
Add support for loading resources from multiple locations #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0041a08
Initial plan
Copilot e77daa3
Add support for multiple resource locations via AdditionalResourcesPaths
Copilot e122ce7
Optimize resource loading to avoid redundant file I/O
Copilot ec0bb44
Change ResourcesPath from string to string[] for multiple location su…
Copilot 9e73616
Merge branch 'main' into copilot/add-resource-loading-support
hishamco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
src/My.Extensions.Localization.Json/JsonLocalizationOptions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| using Microsoft.Extensions.Localization; | ||
| using System.Collections.Generic; | ||
| using Microsoft.Extensions.Localization; | ||
|
|
||
| namespace My.Extensions.Localization.Json; | ||
|
|
||
| public class JsonLocalizationOptions : LocalizationOptions | ||
| { | ||
| public ResourcesType ResourcesType { get; set; } = ResourcesType.TypeBased; | ||
|
|
||
| public IList<string> AdditionalResourcesPaths { get; set; } = new List<string>(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
test/My.Extensions.Localization.Json.Tests/AdditionalResources/Common/Test.fr-FR.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "AdditionalKey": "Clé supplémentaire", | ||
| "Welcome": "Bienvenue" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot we could change
ResourcesPathinstead of introducing a new propertyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean changing
ResourcesPathfrom a single string to a collection (likeIList<string>), so users can specify multiple paths directly? That would be a breaking change for existing users since it changes the type. Could you clarify the preferred approach?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
string[]instead as the return type. Don't worry about the breaking change, this will be included as part of the4.0.0releaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot, apply the changes based on my above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
ResourcesPathfromstringtostring[]in commit ec0bb44. Removed the separateAdditionalResourcesPathsproperty.