DTSRD-4329. flyway script to add skills into skill table#1081
Open
SabinaHMCTS wants to merge 46 commits intomasterfrom
Open
DTSRD-4329. flyway script to add skills into skill table#1081SabinaHMCTS wants to merge 46 commits intomasterfrom
SabinaHMCTS wants to merge 46 commits intomasterfrom
Conversation
lukasz-wolski
previously approved these changes
Sep 2, 2025
Contributor
lukasz-wolski
left a comment
lukasz-wolski
left a comment
There was a problem hiding this comment.
approved with comments inlined
src/integrationTest/resources/db/testmigration/V1_26__insert_skill_table.sql
Outdated
Show resolved
Hide resolved
| assertThat(serviceSkills.size()).isEqualTo(SKILL_COUNT); | ||
|
|
||
| for (ServiceSkill ss: serviceSkills) { | ||
| log.info(":::: skill fetched is" + ss.getId()); |
Contributor
There was a problem hiding this comment.
readability: a space after 'is' would make id value clearer
lukasz-wolski
previously approved these changes
Sep 4, 2025
rajkatla-hmcts
requested changes
Oct 23, 2025
| public static final String STAFF_REF_DATA_SKILL_URL = "/refdata/case-worker/skill"; | ||
| public static final String STAFF_REF_DATA_RD_STAFF_UI_KEY = | ||
| "StaffRefDataController.retrieveAllServiceSkills"; | ||
| public static final int SKILL_COUNT = 5; |
Contributor
There was a problem hiding this comment.
its not skill count, its a service ids count, rename to reflect the same
| "StaffRefDataController.retrieveAllServiceSkills"; | ||
| public static final int SKILL_COUNT = 5; | ||
| public static final int AAA7_SKILL_COUNT = 2; | ||
| public static final int HRS1_SKILL_COUNT = 15; |
Contributor
There was a problem hiding this comment.
Rename this variable name to HRS_SKILL_COUNT from HRS1_SKILL_COUNT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
DTSRD-4329 "Add new Skills for HRS Service"
Change description
flyway script to add HRS skills into skill table
Does this PR introduce a breaking change? (check one with "x")