Fix timestamp ticks decoding mask #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
lboue
reviewed
Dec 26, 2025
Thread defines the Timestamp Ticks field as 15 bits. The parser was using a mask of `0x7FF` (11 bits), which truncated higher tick values. This changes the mask to `0x7FFF` to correctly decode the full 15-bit value. Related to home-assistant/core#134306
|
That seems correct to me; it corresponds to what we find here: timestamp.hpp#L179-L180 static constexpr uint8_t kTicksOffset = 1;
static constexpr uint16_t kTicksMask = 0x7fff << kTicksOffset; |
Collaborator
|
@MartB You really should create a topic branch for PRs instead of submitting PRs from your fork's main branch (for your own sake, it doesn't matter for us). |
emontnemery
approved these changes
Jan 8, 2026
Collaborator
emontnemery
left a comment
emontnemery
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for fixing this @MartB 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread defines the Timestamp Ticks field as 15 bits. The parser was using a mask of
0x7FF(11 bits), which truncated higher tick values.This changes the mask to
0x7FFFto correctly decode the full 15-bit value.Related to home-assistant/core#134306
If this ends up being merged, bumping the dependency of the thread component would be nice!