Add reload updates for main components #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add /reload_updates endpoint which refreshes updates of the main components only (OS, Supervisor, Core and Plug-ins).
14 tasks
sairon
requested changes
Apr 24, 2025
Collaborator
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
A simple test case (like test_refresh_updates) should be added here as well.
sairon
reviewed
Apr 24, 2025
sairon
approved these changes
Apr 24, 2025
aiohasupervisor/root.py
Outdated
| """Refresh updates (discouraged).""" | ||
| """Refresh updates. | ||
| Discouraged. Use the `reload_updates()` and `store.reload()` instead. |
Contributor
There was a problem hiding this comment.
I'd say something about why it is discouraged.
Collaborator
Author
There was a problem hiding this comment.
Updated. Not sure if that is a good reason really, but it is why I plan to not use the endpoint from Core side anymore. With that, this endpoint likely has no users at all, so I'd rather prefer to remove it at one point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add /reload_updates endpoint which refreshes updates of the main components only (OS, Supervisor, Core and Plug-ins).