Skip to content

Add reload updates for main components #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Add reload updates for main components #90

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f036e77
Add reload updates for main components
agners Apr 24, 2025
099ee69
Discourage /refresh_updates only
agners Apr 24, 2025
a3a0632
Add pytest
agners Apr 24, 2025
4e23dc6
Add discouraged explanation
agners Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions aiohasupervisor/root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,14 @@ async def reload_updates(self) -> None:
await self._client.post("reload_updates", timeout=ClientTimeout(total=300))

async def refresh_updates(self) -> None:
"""Refresh updates (discouraged)."""
"""Refresh updates.
Discouraged. Use the `reload_updates()` and `store.reload()` instead.
Copy link
Contributor

@MartinHjelmare MartinHjelmare Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say something about why it is discouraged.

Copy link
Collaborator Author

@agners agners Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Not sure if that is a good reason really, but it is why I plan to not use the endpoint from Core side anymore. With that, this endpoint likely has no users at all, so I'd rather prefer to remove it at one point.

"""
await self._client.post("refresh_updates", timeout=ClientTimeout(total=300))

async def available_updates(self) -> list[AvailableUpdate]:
"""Get available updates (discouraged)."""
"""Get available updates."""
result = await self._client.get("available_updates")
return AvailableUpdates.from_dict(result.data).available_updates

Expand Down
11 changes: 11 additions & 0 deletions tests/test_root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ async def test_available_updates(
assert updates[1].update_type == UpdateType.OS


async def test_reload_updates(
responses: aioresponses, supervisor_client: SupervisorClient
) -> None:
"""Test reload updates API."""
responses.post(f"{SUPERVISOR_URL}/reload_updates", status=200)
assert await supervisor_client.reload_updates() is None
assert responses.requests.keys() == {
("POST", URL(f"{SUPERVISOR_URL}/reload_updates"))
}


async def test_refresh_updates(
responses: aioresponses, supervisor_client: SupervisorClient
) -> None:
Expand Down