-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Add support for action buttons to ntfy integration #152014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
cr7pt0gr4ph7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @tr4nt0r!
Code looks generally good to me 👍 See code review comments for a small nitpick + an open design question.
8d396b5 to
540f59c
Compare
4c32be0 to
5310d4f
Compare
|
hassfest CI failure seems unrelated, something about apt cache. Locally hassfest runs without issues. |
cr7pt0gr4ph7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small rewording suggestion. LGTM otherwise 👍 Thank you, @tr4nt0r!
b788f97 to
dedc1ca
Compare
dedc1ca to
729ec83
Compare
729ec83 to
6e5ea86
Compare
|
really waiting for this, this is the only big feature missing in the core integration |
Proposed change
Extends the
ntfy.publishaction with support for defining action buttons.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: