-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Add support for action buttons to ntfy integration #152014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tr4nt0r
wants to merge
11
commits into
home-assistant:dev
Choose a base branch
from
tr4nt0r:ntfy_button_actions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+199
−5
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1eab570
Add support for button actions to ntfy
tr4nt0r 09edf42
tests
tr4nt0r dc3375b
selector translations
tr4nt0r e241d7e
rework object selector schema
tr4nt0r e987db5
comment
tr4nt0r 391bfbb
remove unused strings
tr4nt0r ddb5d82
empty
tr4nt0r 6e5ea86
strings
tr4nt0r c753e13
fix prettier sorting
tr4nt0r cf6650b
Merge branch 'dev' into ntfy_button_actions
tr4nt0r c99ba0d
Merge branch 'dev' into ntfy_button_actions
tr4nt0r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| from typing import Any | ||
|
|
||
| from aiontfy import Message | ||
| from aiontfy import BroadcastAction, HttpAction, Message, ViewAction | ||
| from aiontfy.exceptions import ( | ||
| NtfyException, | ||
| NtfyHTTPError, | ||
|
|
@@ -14,6 +14,7 @@ | |
| from homeassistant.components.notify import ATTR_MESSAGE, ATTR_TITLE | ||
| from homeassistant.components.ntfy.const import DOMAIN | ||
| from homeassistant.components.ntfy.notify import ( | ||
| ATTR_ACTIONS, | ||
| ATTR_ATTACH, | ||
| ATTR_CALL, | ||
| ATTR_CLICK, | ||
|
|
@@ -60,6 +61,29 @@ async def test_ntfy_publish( | |
| ATTR_MARKDOWN: True, | ||
| ATTR_PRIORITY: "5", | ||
| ATTR_TAGS: ["partying_face", "grin"], | ||
| ATTR_ACTIONS: [ | ||
| { | ||
| "action": "broadcast", | ||
| "label": "Take picture", | ||
| "intent": "com.example.AN_INTENT", | ||
| "extras": {"cmd": "pic"}, | ||
| "clear": True, | ||
| }, | ||
| { | ||
| "action": "view", | ||
| "label": "Open website", | ||
| "url": "https://example.com", | ||
| "clear": False, | ||
| }, | ||
| { | ||
| "action": "http", | ||
| "label": "Close door", | ||
| "url": "https://api.example.local/", | ||
| "method": "PUT", | ||
| "headers": {"Authorization": "Bearer ..."}, | ||
| "clear": False, | ||
| }, | ||
| ], | ||
| }, | ||
| blocking=True, | ||
| ) | ||
|
|
@@ -76,6 +100,27 @@ async def test_ntfy_publish( | |
| markdown=True, | ||
| icon=URL("https://example.org/logo.png"), | ||
| delay="86430.0s", | ||
| actions=[ | ||
| BroadcastAction( | ||
| label="Take picture", | ||
| intent="com.example.AN_INTENT", | ||
| extras={"cmd": "pic"}, | ||
| clear=True, | ||
| ), | ||
| ViewAction( | ||
| label="Open website", | ||
| url="https://example.com", | ||
| clear=False, | ||
| ), | ||
| HttpAction( | ||
| label="Close door", | ||
| url="https://api.example.local/", | ||
| method="PUT", | ||
| headers={"Authorization": "Bearer ..."}, | ||
| body=None, | ||
| clear=False, | ||
| ), | ||
| ], | ||
| ) | ||
| ) | ||
|
|
||
|
|
@@ -142,12 +187,23 @@ async def test_send_message_exception( | |
| {ATTR_DELAY: {"days": 1, "seconds": 30}, ATTR_EMAIL: "[email protected]"}, | ||
| "Delayed email notifications are not supported", | ||
| ), | ||
| ( | ||
| { | ||
| ATTR_ACTIONS: [ | ||
| {"action": "broadcast", "label": "1"}, | ||
| {"action": "broadcast", "label": "2"}, | ||
| {"action": "broadcast", "label": "3"}, | ||
| {"action": "broadcast", "label": "4"}, | ||
| ], | ||
| }, | ||
| "Too many actions defined. A maximum of 3 is supported", | ||
| ), | ||
| ], | ||
| ) | ||
| @pytest.mark.usefixtures("mock_aiontfy") | ||
| async def test_send_message_validation_errors( | ||
| hass: HomeAssistant, | ||
| config_entry: MockConfigEntry, | ||
| mock_aiontfy: AsyncMock, | ||
| payload: dict[str, Any], | ||
| error_msg: str, | ||
| ) -> None: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.