Skip to content

Set PARALLEL_UPDATES for WLED #155573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2025
+7 −0
Merged

Set PARALLEL_UPDATES for WLED #155573

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbffdab
Set PARALLEL_UPDATES for WLED
mik-laj Oct 31, 2025
4e970ae
Enable concurrent data updates in WLED button
mik-laj Nov 2, 2025
a294ffb
Enable concurrent updates for WLED component
mik-laj Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions homeassistant/components/wled/button.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
from .entity import WLEDEntity
from .helpers import wled_exception_handler

# Coordinator is used to centralize the data updates
PARALLEL_UPDATES = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually not quite true. The coordinator only parallelizes the incoming data updates. Outgoing, like pressing the buttons, are not parallelized. So is the API able to handle potentially parallell requests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We have only one button - Reset and I think there should be no parallelism here.



async def async_setup_entry(
hass: HomeAssistant,
Expand Down
3 changes: 3 additions & 0 deletions homeassistant/components/wled/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
from .coordinator import WLEDDataUpdateCoordinator
from .entity import WLEDEntity

# Coordinator is used to centralize the data updates
PARALLEL_UPDATES = 0


@dataclass(frozen=True, kw_only=True)
class WLEDSensorEntityDescription(SensorEntityDescription):
Expand Down
3 changes: 3 additions & 0 deletions homeassistant/components/wled/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
from .entity import WLEDEntity
from .helpers import wled_exception_handler

# Coordinator is used to centralize the data updates
PARALLEL_UPDATES = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same applies to async_update here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Thank you very much for pointing this out.



async def async_setup_entry(
hass: HomeAssistant,
Expand Down
Loading