Skip to content

Conversation

@EuleMitKeule
Copy link
Contributor

Breaking change

Proposed change

This fixes an issue with ObjectSelector instances. The tests for this selector indicate that it should be possible to use an instance of another selector for a field of the object selector. This didn't actually work/broke in some recent version of HASS (at least not for the kinds of selectors I use in my custom integrations inside object selectors).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings January 3, 2026 03:55
@EuleMitKeule EuleMitKeule requested a review from a team as a code owner January 3, 2026 03:55
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jan 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the ObjectSelector validation logic where it failed to handle Selector instances directly in field configurations. The ObjectSelector supports both dictionary-based selector configs and Selector instances (as shown in the type definition and tests), but the validation code in __call__ only handled dictionary configs. This resulted in a TypeError when trying to call the selector() function on a Selector instance.

Key Changes

  • Modified the __call__ method in ObjectSelector to check if the field selector is already a Selector instance before attempting to instantiate it
  • Added type-based branching to handle both Selector instances and dictionary configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed core small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant