Skip to content

Bugfix: Actually allow usage of Selector instances for object selector fields #160171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EuleMitKeule wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −1
Open

Bugfix: Actually allow usage of Selector instances for object selector fields #160171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion homeassistant/helpers/selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,12 @@ def __call__(self, data: Any) -> Any:
if field_data.get("required") and field not in _config:
raise vol.Invalid(f"Field {field} is required")
if field in _config:
selector(field_data["selector"])(_config[field]) # type: ignore[operator]
field_selector = field_data["selector"]
# Handle both Selector instances and dict configs
if isinstance(field_selector, Selector):
field_selector(_config[field]) # type: ignore[operator]
else:
selector(field_selector)(_config[field]) # type: ignore[operator]

for key in _config:
if key not in self.config["fields"]:
Expand Down
Loading