-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add support for service action description placeholders #27636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add support for service action description placeholders #27636
Conversation
Examples are only shown in yaml mode, in the little table under the editor. Also used when clicking |
|
I believe #27640 will fix what you describe as pre-existing bug #1/#2 |
292fce5 to
fb817ff
Compare
|
Core PR and JS-API PR were approved |
Rebased. Issues are resolved. This PR needs a review. |
|
@karwosts what is the next step here? As the Core and JS-API changes are approved, should we finish the review here first? The linter errors will remain till the JS-API PR as been merged. Let me know what I can do. |
|
Sorry I'd say that's above my pay grade 😅 . I will let the main maintainers decide how and when to merge this. |
98859db to
02e3589
Compare
Proposed change
Add support for service action description placeholders
An example is added via the Core PR using the Kitchen Sink integration.
Type of change
Example configuration
Setup Kitchen sink to validate the PR with action
kitchen_sink.test_service_1Service definition:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: