Regenerate service-picker valueRenderer on localize update #27640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
MindFreeze
reviewed
Oct 26, 2025
src/components/ha-service-picker.ts
Outdated
| const serviceId = value; | ||
| const [domain, service] = serviceId.split("."); | ||
|
|
||
| if (!this.hass.services[domain]?.[service]) { |
Member
There was a problem hiding this comment.
Should services also be memoized? It is in _getItems
Member
Author
There was a problem hiding this comment.
Seems like that would make sense.
Contributor
|
I've tested the fix. And it looks good in the UI. |
MindFreeze
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Ensure the service name in the service picker value is always translated.
Currently there is no hass object down where the valueRenderer is called, so it doesn't know to rerun the valueRenderer when hass.localize changes.
This PR regenerates the valueRenderer function object when hass.localize changes, so that this change propagates down to the ha-picker-field and triggers a rerender.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: